Revert changes to servo_arc, style_derive, and style_traits #31387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the Rust edition updates to these three traits as well as incorporates https://phabricator.services.mozilla.com/D117887. The purpose of this change is to reduce the diff with upstream stylo. Finally, formatting is disabled for these crates as well.
mrobinson
force-pushed
the
revert-changes-to-various-crates
branch
from
e4a39a1
to
d0c16cc
Compare
delan
approved these changes
Feb 22, 2024
delan
pushed a commit
to servo/stylo
that referenced
this pull request
Feb 22, 2024
This builds successfully with: $ cargo build --features servo (as of servo#31351, 31363, 31358, 31365) This patch is up to date as of: * servo/servo#31351 * servo/servo#31363 * servo/servo#31358 * servo/servo#31365 * servo/servo#31387 * servo/servo#31408
delan
pushed a commit
to servo/stylo
that referenced
this pull request
Feb 22, 2024
This builds successfully with: $ cargo build --features servo (as of servo#31351, 31363, 31358, 31365) This patch is up to date as of: * servo/servo#31351 * servo/servo#31363 * servo/servo#31358 * servo/servo#31365 * servo/servo#31387 * servo/servo#31408
mrobinson
added a commit
to servo/stylo
that referenced
this pull request
Feb 23, 2024
This builds successfully with: $ cargo build --features servo (as of servo#31351, 31363, 31358, 31365) This patch is up to date as of: * servo/servo#31351 * servo/servo#31363 * servo/servo#31358 * servo/servo#31365 * servo/servo#31387 * servo/servo#31408
delan
pushed a commit
to servo/stylo
that referenced
this pull request
Feb 23, 2024
This builds successfully with: $ cargo build --features servo (as of servo#31351, 31363, 31358, 31365) This patch is up to date as of: * servo/servo#31351 * servo/servo#31363 * servo/servo#31358 * servo/servo#31365 * servo/servo#31387 * servo/servo#31408
delan
pushed a commit
to servo/stylo
that referenced
this pull request
Feb 23, 2024
This builds successfully with: $ cargo build --features servo (as of servo#31351, 31363, 31358, 31365) This patch is up to date as of: * servo/servo#31351 * servo/servo#31363 * servo/servo#31358 * servo/servo#31365 * servo/servo#31387 * servo/servo#31408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the Rust edition updates to these three traits as well as
incorporates https://phabricator.services.mozilla.com/D117887. The
purpose of this change is to reduce the diff with upstream stylo.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors