Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move servoshell code into an internal lib crate #31439

Merged
merged 2 commits into from Feb 28, 2024

Conversation

delan
Copy link
Sponsor Member

@delan delan commented Feb 28, 2024

This patch moves as much of servoshell’s code as possible from the “servo” bin crate (not to be confused with the “servo” lib crate in libservo) to a “servoshell” lib crate in the same package. As a result:

  • we can get rid of ports/servoshell/main2.rs
  • you can now distinguish servoshell logging from libservo (RUST_LOG=servoshell vs RUST_LOG=servo)
  • cargo timings now list how much time we spend on servoshell’s codegen

image


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because there are no functional changes

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also mean to remove main2.rs in this change as well?

@atbrakhi
Copy link
Member

Did you also mean to remove main2.rs in this change as well?

main2.rs is lib.rs now

ports/servoshell/lib.rs Outdated Show resolved Hide resolved
@delan delan enabled auto-merge February 28, 2024 08:29
@delan delan added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@delan delan added this pull request to the merge queue Feb 28, 2024
Merged via the queue into servo:main with commit 6a3cd65 Feb 28, 2024
9 checks passed
@delan delan deleted the split-servoshell-bin-lib branch February 28, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants