fix invalid video poster image loading from panicking #31447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed servo#31438. When an image is loaded from cache, it will load a placeholder if the url is not a valid image url. This may be unexpected when using the image cache and specifying UsePlaceholder::No but that has no effect on loading an image not in the cache. Signed-off-by: Sebastian C <sebsebmc@gmail.com>
mrobinson
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #31438. When an image is loaded from cache, it will load a placeholder if the url is not a valid image url. This may be unexpected when using the image cache and specifying UsePlaceholder::No but that has no effect on loading an image not in the cache.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsI didnt spot any WPT tests for this so maybe one needs to be made?