Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: fix warnings in components/gfx #31560

Merged
merged 4 commits into from Mar 8, 2024
Merged

Conversation

eerii
Copy link
Contributor

@eerii eerii commented Mar 7, 2024

Split from #31514, fixes most clippy warnings in components/gfx.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they do not modify functionality, they only fix lint errors.

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out!

@mrobinson mrobinson enabled auto-merge March 7, 2024 19:27
auto-merge was automatically disabled March 7, 2024 19:28

Head branch was pushed to by a user without write access

@eerii
Copy link
Contributor Author

eerii commented Mar 7, 2024

Oh sorry about that @mrobinson, I was switching the order of PartialOrd and Ord so it was clearer, and it disabled the merge.

@mrobinson mrobinson enabled auto-merge March 7, 2024 19:40
@mrobinson mrobinson added this pull request to the merge queue Mar 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2024
@mrobinson mrobinson added this pull request to the merge queue Mar 8, 2024
Merged via the queue into servo:main with commit 88033bd Mar 8, 2024
9 checks passed
@eerii eerii deleted the clippy_gfx branch March 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants