Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustdoc errors in components/shared #31582

Merged
merged 3 commits into from Mar 8, 2024

Conversation

Aaryakhandelwal
Copy link
Contributor

@Aaryakhandelwal Aaryakhandelwal commented Mar 8, 2024

  1. To fix error in components>shared>embedder>lib.rs: Changed the "unclosed" HTML tag to an inline code using back ticks.
  2. To fix error in components>shared>net>request.rs: Added to convert into clickable link.
  3. To fix error in components>shared>script>lib.rs: Added closing bracket (>) to fix error.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many rustdoc errors as possible #31575
  • There are tests for these changes --> Run the command ./mach doc. There shouldn't be any errors/warnings in the above mentioned.

@atbrakhi atbrakhi changed the title Outreachy Fix rustdoc errors in components/shared Mar 8, 2024
@mrobinson
Copy link
Member

Thank you!

@mrobinson mrobinson enabled auto-merge March 8, 2024 11:41
@mrobinson mrobinson added this pull request to the merge queue Mar 8, 2024
Merged via the queue into servo:main with commit dd6c929 Mar 8, 2024
12 checks passed
@Aaryakhandelwal Aaryakhandelwal deleted the Outreachy branch March 12, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants