layout: Do not inherit node and fragment flags in anonymous boxes #31586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#8205014162) for Linux WPT |
Loirooriol
reviewed
Mar 8, 2024
| style, | ||
| } | ||
| } | ||
|
|
||
| pub(crate) fn new_replacing_style(&self, style: ServoArc<ComputedValues>) -> Self { |
There was a problem hiding this comment.
Should all callers of this use new_anonymous?
There was a problem hiding this comment.
I chose to keep it for a couple callers which expect things to be inherited or which are creating list markers. There's a larger refactor we should do to clean this up and we need to implement the ::marker pseudo, but these are pretty intrusive things that should be done in a larger project.
|
Test results for linux-wpt-layout-2020 from try job (#8205014162): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (18)
|
|
✨ Try run (#8205014162) succeeded. |
Loirooriol
approved these changes
Mar 9, 2024
Comment on lines
966
to
974
| let (rowspan, colspan) = info | ||
| .node | ||
| .map(|node| { | ||
| let node = node.to_threadsafe(); | ||
| let rowspan = (node.get_rowspan().unwrap_or(1) as usize).min(65534); | ||
| let colspan = (node.get_colspan().unwrap_or(1) as usize).min(1000); | ||
| (rowspan, colspan) | ||
| }) | ||
| .unwrap_or((1, 1)); |
There was a problem hiding this comment.
Suggested change
| let (rowspan, colspan) = info | |
| .node | |
| .map(|node| { | |
| let node = node.to_threadsafe(); | |
| let rowspan = (node.get_rowspan().unwrap_or(1) as usize).min(65534); | |
| let colspan = (node.get_colspan().unwrap_or(1) as usize).min(1000); | |
| (rowspan, colspan) | |
| }) | |
| .unwrap_or((1, 1)); | |
| let (rowspan, colspan) = info.node.map_or((1, 1), |node| { | |
| let node = node.to_threadsafe(); | |
| let rowspan = node.get_rowspan().unwrap_or(1).min(65534) as usize; | |
| let colspan = node.get_colspan().unwrap_or(1).min(1000) as usize; | |
| (rowspan, colspan) | |
| }); |
components/layout_2020/table/mod.rs
Outdated
Comment on lines
146
to
149
| self.base_fragment_info | ||
| .tag | ||
| .map(|tag| tag.node.0) | ||
| .unwrap_or(0) |
There was a problem hiding this comment.
Suggested change
| self.base_fragment_info | |
| .tag | |
| .map(|tag| tag.node.0) | |
| .unwrap_or(0) | |
| self.base_fragment_info.tag.map_or(0, |tag| tag.node.0) |
This doesn't really have observable behavior right now, as much as I tried to trigger some kind of bug. On the other hand, it's just wrong and is very obvious when you dump the Fragment tree. If you create a `display: table-cell` that is a child of the `<body>` all parts of the anonymous table are flagged as if they are the `<body>` element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't really have observable behavior right now, as much as I
tried to trigger some kind of bug. On the other hand, it's just wrong
and is very obvious when you dump the Fragment tree. If you create a
display: table-cellthat is a child of the<body>all parts of theanonymous table are flagged as if they are the
<body>element../mach build -ddoes not report any errors./mach test-tidydoes not report any errors