layout: Properly parent table-row and table-row-group #31619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#8236896416) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8236896416): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (24)
|
|
|
mrobinson
force-pushed
the
row-rowgroup-parenting
branch
from
b8155b9
to
d827e36
Compare
|
🔨 Triggering try run (#8245824214) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8245824214): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (5)
|
|
|
Loirooriol
approved these changes
Mar 13, 2024
| @@ -26,7 +26,7 @@ pub type LengthOrAuto = AutoOr<Length>; | |||
| pub type AuOrAuto = AutoOr<Au>; | |||
| pub type LengthPercentageOrAuto<'a> = AutoOr<&'a LengthPercentage>; | |||
|
|
|||
| #[derive(Clone, Serialize)] | |||
| #[derive(Clone, Copy, Serialize)] | |||
There was a problem hiding this comment.
Then there is a bunch of existing .clone() that become unnecessary. Should they be removed here, or be left for a follow-up?
There was a problem hiding this comment.
Good point. In addition to the cleanup that we can do now that AddAssign and SubAssign don't need to take references for LogicalVec, I think this can be in a followup.
Comment on lines
679
to
682
| let row_group = self | ||
| .current_row_group_index | ||
| .map(|index| &mut self.builder.table.row_groups[index]); | ||
| if let Some(row_group) = row_group { | ||
| row_group.track_range.end = last_row; | ||
| } |
There was a problem hiding this comment.
Nit: this seems simpler as
if let Some(index) = self.current_row_group_index {
let row_group = &mut self.builder.table.row_groups[index];
row_group.track_range.end = last_row;
}
Put table cell content fragments into a hieararchy of fragments that include their table row and table row group fragments. This ensures that things like relative positioning and transforms set on rows and row groups properly affect cells and cell content. Co-authored-by: Oriol Brufau <obrufau@igalia.com>
mrobinson
force-pushed
the
row-rowgroup-parenting
branch
from
d827e36
to
179a613
Compare
mrobinson
commented
Mar 14, 2024
| @@ -26,7 +26,7 @@ pub type LengthOrAuto = AutoOr<Length>; | |||
| pub type AuOrAuto = AutoOr<Au>; | |||
| pub type LengthPercentageOrAuto<'a> = AutoOr<&'a LengthPercentage>; | |||
|
|
|||
| #[derive(Clone, Serialize)] | |||
| #[derive(Clone, Copy, Serialize)] | |||
There was a problem hiding this comment.
Good point. In addition to the cleanup that we can do now that AddAssign and SubAssign don't need to take references for LogicalVec, I think this can be in a followup.
|
There are a few new failures here. At least one or two of these are due to tests expecting that a transform on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put table cell content fragments into a hieararchy of fragments that
include their table row and table row group fragments. This ensures that
things like relative positioning and transforms set on rows and row
groups properly affect cells and cell content.
Co-authored-by: Oriol Brufau obrufau@igalia.com
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors