Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings in components/third_party #31623

Merged
merged 1 commit into from Mar 12, 2024
Merged

Fix clippy warnings in components/third_party #31623

merged 1 commit into from Mar 12, 2024

Conversation

mnaibei
Copy link
Contributor

@mnaibei mnaibei commented Mar 12, 2024 •
edited by atbrakhi

Fixing Clippy linter errors in components/third_party folder

  • These changes do not require tests because they do not modify functionality, they only fix lint errors.

@mrobinson mrobinson added the T-macos Do a try run on MacOS label Mar 12, 2024
@github-actions github-actions bot removed the T-macos Do a try run on MacOS label Mar 12, 2024
@github-actions GitHub Actions
Copy link

🔨 Triggering try run (#8252122485) for MacOS

mrobinson
mrobinson approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, I would say that we should be making these kind of changes in third_party, but blurmac is a dead project so this is very low risk and I don't even think it makes sense to create a patch for this like we do for most members of third_party.

@github-actions GitHub Actions
Copy link

✨ Try run (#8252122485) succeeded.

@mrobinson mrobinson added this pull request to the merge queue Mar 12, 2024
Merged via the queue into servo:main with commit 4efebf1 Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnaibei @mrobinson