Fix rustdoc errors in components/layout_2020
#31624
Conversation
…nk by changing syntax
atbrakhi
changed the title
components/layout_2020
| @@ -173,7 +173,7 @@ struct LineUnderConstruction { | |||
| /// offset from `text-indent`. | |||
| start_position: LogicalVec2<Length>, | |||
|
|
|||
| /// The current inline position in the line being laid out into [`LineItems`] in this | |||
| /// The current inline position in the line being laid out into LineItems in this | |||
There was a problem hiding this comment.
Converting [`LineItems`] to LineItems is not the correct solution here. This should be [`LineItem`]s instead. For reference you can see some examples here
| @@ -187,7 +187,7 @@ struct LineUnderConstruction { | |||
| has_content: bool, | |||
|
|
|||
| /// Whether or not there are floats that did not fit on the current line. Before | |||
| /// the [`LineItems`] of this line are laid out, these floats will need to be | |||
| /// the LineItems of this line are laid out, these floats will need to be | |||
| @@ -604,7 +604,7 @@ pub(super) struct InlineFormattingContextState<'a, 'b> { | |||
| /// of the inline box is the state popped from the stack. | |||
| inline_box_state_stack: Vec<InlineBoxContainerState>, | |||
|
|
|||
| /// A vector of fragment that are laid out. This includes one [`Fragment::Anonymous`] | |||
| /// A vector of fragment that are laid out. This includes one Fragment::Anonymous | |||
There was a problem hiding this comment.
we should not remove [` and `], we still want it to be a link. Anonymous was removed in this PR hence Rust doc is complaining, this should be [` Fragment::Positioning `] now.
|
Should I create a new pull request with the changes |
You should update this pull request with the new version of your changes. See mislav/hub#198. |
Yes I did, could you check once |
Your change now includes unrelated changes from other PRs. Do you mind rebasing it onto the latest from the main branch and making sure it just includes the changes you are trying to make? |
…nk by changing syntax
* Add wpt-report artifact * Merge logs (filtered) are last so we still get other logs merged * fixup * it's wptreport.json * wptreport in full artifact * Apply suggestions from code review Co-authored-by: Martin Robinson <mrobinson@igalia.com> --------- Co-authored-by: Martin Robinson <mrobinson@igalia.com>
I have re based it to the updated main branch. I can see the updated changes in my system locally. Could you check it once, if it's alright. |
No, it still seems to include too many changes. I recommend not doing any merges from main when creating a pull request. If you look at the "Files changed" tab in GitHub you can see that there are too many changes included in this PR due to the merge commits in your branch. The simplest thing to do now might be to redo these changes in a new PR. |
|
Yes, I will just create a new pr. Thanks for your help.
…On Wed, 13 Mar 2024, 13:49 Martin Robinson, ***@***.***> wrote:
I have re based it to the updated main branch. I can see the updated
changes in my system locally. Could you check it once, if it's alright.
No, it still seems to include too many changes. I recommend not doing any
merges from main when creating a pull request. If you look at the "Files
changed" tab in GitHub you can see that there are too many changes included
in this PR due to the merge commits in your branch. The simplest thing to
do now might be to redo these changes in a new PR.
—
Reply to this email directly, view it on GitHub
<#31624 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4MI2XG66CZ2KE2AC7IWQKLYYAD2LAVCNFSM6AAAAABESJB3UKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJTG44TGOBZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
1)There were no function named as LineItems, thus removed the link syntax.
2) There was no variant named as Anonymous within the Fragment, thus removed the link syntax
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors