Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Fix warnings in components/net #31626

Merged
merged 2 commits into from Mar 13, 2024
Merged

clippy: Fix warnings in components/net #31626

merged 2 commits into from Mar 13, 2024

Conversation

eerii
Copy link
Contributor

@eerii eerii commented Mar 12, 2024

Continuation to #31500, fixes all clippy warnings in components/net (excluding safety comments).


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they do not modify functionality, they only fix lint errors.

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple small comments:

components/net/fetch/methods.rs Outdated Show resolved Hide resolved
components/net/filemanager_thread.rs Outdated Show resolved Hide resolved
@mrobinson mrobinson added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@mrobinson mrobinson added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@mrobinson
Copy link
Member

Opened #31638 for this intermittent. Sending back to the MQ.

@mrobinson mrobinson added this pull request to the merge queue Mar 13, 2024
Merged via the queue into servo:main with commit 63527f5 Mar 13, 2024
9 checks passed
@eerii eerii deleted the clippy_net branch March 14, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants