clippy: Fix assorted warnings in components/
#31628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation to #31500, fixes clippy warnings in the rest of
components/modules (excluding all those inscriptand the ones about safety comments and result types).It includes the following allows that seem to be reasonable:
upper_case_acronyms: in the case ofWGPUI think it looks better and more correct thanWgpu.wrong_self_convention: incompositing/compositor.rs, a function namedfrom_webrenderis used to turnWebRenderPipelineIdintoPipelineId. I can't think of a name that better represents this conversion, if anyone has ideas for this please do say them.large_enum_variant: same as in clippy: Fix warnings incomponents/constellation#31610./mach build -ddoes not report any errors./mach test-tidydoes not report any errors