rustdoc: Fix some typos in components/layout_2020/table/mod.rs
#31644
Conversation
There was a problem hiding this comment.
This PR removes a lot of code and documentation unnecessarily. Is this the results of pasting the code into an AI model and then just pasting the results into the file? Please don't do that. At the very least, make sure the code changes compile locally. This is what we ask in the commit template and it's good practice contributing to open source projects.
components/layout_2020/table/mod.rs
Outdated
| #[derive(Clone, Debug, Serialize)] | ||
| pub struct TableTrack { | ||
| /// The [`BaseFragmentInfo`] of this cell. | ||
| /// The BaseFragmentInfo of this cell. |
There was a problem hiding this comment.
| /// The BaseFragmentInfo of this cell. | |
| /// The BaseFragmentInfo of this cell. |
Rather than removing the link, let's import the struct via a use statement. It should be public enough.
components/layout_2020/table/mod.rs
Outdated
| @@ -256,32 +83,26 @@ pub struct TableTrack { | |||
| /// groups. | |||
| group_index: Option<usize>, | |||
|
|
|||
| /// Whether or not this [`TableTrack`] was anonymous, for instance created due to | |||
| /// Whether or not this TableTrack was anonymous, for instance created due to | |||
There was a problem hiding this comment.
This change is unnecessary and removes the link.
components/layout_2020/table/mod.rs
Outdated
| /// The BaseFragmentInfo of this TableTrackGroup. | ||
| base_fragment_info: BaseFragmentInfo, | ||
|
|
||
| /// The style of this [`TableTrackGroup`]. | ||
| /// The style of this TableTrackGroup. | ||
| #[serde(skip_serializing)] | ||
| style: Arc<ComputedValues>, | ||
|
|
||
| /// The type of this [`TableTrackGroup`]. | ||
| /// The type of this TableTrackGroup. | ||
| group_type: TableTrackGroupType, | ||
|
|
||
| /// The range of tracks in this [`TableTrackGroup`]. | ||
| /// The range of tracks in this TableTrackGroup. |
There was a problem hiding this comment.
Please don't remove these links.
|
@mrobinson I really apologize for this carelessness. I'm a bit new to open source, and forgot to read |
No worries. It's okay to use tools to help your work, but please make sure that things are working before opening a pull request. Welcome to the Servo project. If you haven't already, I recommend joining our Zulip chat and introducing yourself. |
|
@ektuu Are you planning on continuing to work on this change? |
mrobinson
force-pushed
the
fix-doc-link-to-private-item
branch
from
18c1da2
to
1a9abc5
Compare
mrobinson
changed the title
components/layout_2020/table/mod.rs
|
I've just preserved the typo fixes here, because they are valid and I'd like to clear out some of the pending PRs. |
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors