fonts: Consider Tertiary Ideographic Plane to be CJK #31670

sandeepB3 · 2024-03-14T16:07:02Z

Added codepoint check for Tertiary Ideographic Plane

test page: data:text/html;charset=utf-8,%F0%B0%BB%9D shows the appropriate character
(when fonts: Add Noto Sans CJK fonts to the Linux fallback list #31668 is also applied)

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix On Linux, use CJK fallback fonts for Tertiary Ideographic Plane #31663

github-actions · 2024-03-14T17:08:10Z

🔨 Triggering try run (#8284778069) for Linux WPT

github-actions · 2024-03-14T18:10:24Z

Test results for linux-wpt-layout-2013 from try job (#8284778069):

Flaky unexpected result (11)

CRASH [expected OK] /_mozilla/mozilla/service-workers/service-worker-registration.https.html (#31036)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected PASS] /css/css-color/animation/opacity-animation-ending-correctly-002.html (#29216)
OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- FAIL [expected PASS] subtest: Smooth scrolling while doing history navigation. assert_not_equals: Shouldn't be scrolled back to top yet. got disallowed value 0
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 5] length 2, got [6, 3, 5] length 3
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (normal form)
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 7575040 but got 7574784
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
ERROR [expected OK] /workers/semantics/run-a-worker/003.html (#22765)

Stable unexpected results that are known to be intermittent (12)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works. Test timed out
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- FAIL [expected PASS] subtest: listeners are called correct number of times assert_equals: expected 3 but got 2
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- FAIL [expected TIMEOUT] subtest: opener of discarded auxiliary browsing context assert_object_equals: property "get" expected function "function opener() {
  [native code]
  }" got function "function opener() {
  [native code]
  }"
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
TIMEOUT /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent Test timed out
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out

github-actions · 2024-03-14T18:11:36Z

Test results for linux-wpt-layout-2020 from try job (#8284778069):

Flaky unexpected result (16)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected PASS] /css/css-color/animation/opacity-animation-ending-correctly-002.html (#29216)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '500' over '400 425'
- PASS [expected FAIL] subtest: Matching font-weight: '500' should prefer '350 399' over '351 398'
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '501' over '502 510'
- PASS [expected FAIL] subtest: Matching font-stretch: '90%' should prefer '90% 100%' over '50% 80%'
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 20deg' over 'oblique 30deg 60deg'
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'normal' over 'oblique 0deg'
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 0deg' over 'oblique -60deg -30deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 10deg' over 'italic'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 20deg' should prefer 'italic' over 'oblique 0deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 21deg' over 'oblique 30deg 60deg'
- And 9 more unexpected results...
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Cross-site, no attributes promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Same site, no attributes Test timed out
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked assert_equals: expected "A" but got ""
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in name (formdata event)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- TIMEOUT [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document Test timed out
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- TIMEOUT [expected FAIL] subtest: Sanity check: this all works as expected with no promises involved Test timed out
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on fulfilled promise Test timed out
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

Stable unexpected results that are known to be intermittent (17)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- FAIL [expected PASS] subtest: calls handleEvent method of event listener assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
CRASH [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-valid.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with URL fragments should be skipped. assert_true: expected true got false
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
- NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_parent does a normal load
OK [expected TIMEOUT] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"
- FAIL [expected TIMEOUT] subtest: Rejection handler on pending-then-rejected promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 5277952 but got 5277696
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

github-actions · 2024-03-14T18:11:46Z

✨ Try run (#8284778069) succeeded.

delan

Thanks! I’ve updated the screenshot in the description, because the screenshot only shows the Chinese character when both #31668 and this patch are applied.

Could you please write a unit test for the new behaviour? One minor comment below, but otherwise it’s looking good.

components/gfx/text/util.rs

delan · 2024-03-15T08:05:48Z

Looks good! Could you please write a unit test for the new behaviour?

sandeepB3 · 2024-03-15T14:20:33Z

Looks good! Could you please write a unit test for the new behaviour?

Sure! I haven't worked with unit testing in Rust, but I'll learn from the Rust docs and give it a try.

Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>

sandeepB3 · 2024-03-15T18:08:41Z

Looks good! Could you please write a unit test for the new behaviour?

Hey @delan, I've added unit tests for the is_cjk function. Please let me know if any changes are required.

Output of test_is_cjk function:

Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>

servo-wpt-sync · 2024-03-17T15:36:32Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

delan

Thanks for the update, there are a couple more comments below.

components/gfx/tests/text_util.rs

Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>

sandeepB3 · 2024-03-18T09:53:27Z

Thanks for the update, there are a couple more comments below.

I have made the commented changes. Please check.

servo-wpt-sync · 2024-03-18T09:53:28Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

delan

Great work, thanks again!

added check for Tertiary Ideographic Plane

2d90fc9

mrobinson added T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Mar 14, 2024

github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Mar 14, 2024

mrobinson changed the title ~~Fix: added check for Tertiary Ideographic Plane~~ fonts: Consider Tertiary Ideographic Plane to be CJK Mar 14, 2024

delan reviewed Mar 15, 2024

View reviewed changes

components/gfx/text/util.rs Show resolved Hide resolved

Merge branch 'main' into cjk-fonts

3800dc6

Sandeep Pillai added 4 commits March 15, 2024 22:56

Merge branch 'main' into cjk-fonts

c685155

Merge branch 'main' into cjk-fonts

c752c7f

added unit test for is_cjk function

d0e568b

Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>

Merge branch 'main' into cjk-fonts

15314c5

Sandeep Pillai added 4 commits March 16, 2024 02:04

Merge branch 'main' into cjk-fonts

a7849f1

Merge branch 'main' into cjk-fonts

ce023ec

fixed formatting

74bb321

Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>

Merge branch 'main' into cjk-fonts

8b3d6d7

delan reviewed Mar 18, 2024

View reviewed changes

components/gfx/tests/text_util.rs Outdated Show resolved Hide resolved

components/gfx/tests/text_util.rs Outdated Show resolved Hide resolved

Sandeep Pillai added 3 commits March 18, 2024 15:07

Merge branch 'main' into cjk-fonts

6f5fb00

removed for loop assertions & added TIP chars

6da9991

Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>

Merge branch 'main' into cjk-fonts

ed063f4

delan approved these changes Mar 18, 2024

View reviewed changes

delan added this pull request to the merge queue Mar 18, 2024

Merged via the queue into servo:main with commit 94c1f2c Mar 18, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fonts: Consider Tertiary Ideographic Plane to be CJK #31670

fonts: Consider Tertiary Ideographic Plane to be CJK #31670

sandeepB3 commented Mar 14, 2024 •

edited

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

delan left a comment •

edited

delan commented Mar 15, 2024

sandeepB3 commented Mar 15, 2024

sandeepB3 commented Mar 15, 2024

servo-wpt-sync commented Mar 17, 2024

delan left a comment

sandeepB3 commented Mar 18, 2024

servo-wpt-sync commented Mar 18, 2024

delan left a comment

fonts: Consider Tertiary Ideographic Plane to be CJK #31670

fonts: Consider Tertiary Ideographic Plane to be CJK #31670

Conversation

sandeepB3 commented Mar 14, 2024 • edited

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

delan left a comment • edited

Choose a reason for hiding this comment

delan commented Mar 15, 2024

sandeepB3 commented Mar 15, 2024

sandeepB3 commented Mar 15, 2024

servo-wpt-sync commented Mar 17, 2024

delan left a comment

Choose a reason for hiding this comment

sandeepB3 commented Mar 18, 2024

servo-wpt-sync commented Mar 18, 2024

delan left a comment

Choose a reason for hiding this comment

sandeepB3 commented Mar 14, 2024 •

edited

delan left a comment •

edited