New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gstreamer plugins good/ugly for better codec support #31687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔨 Triggering try run (#8293298728) for Linux WPT |
Test results for linux-wpt-layout-2020 from try job (#8293298728): Flaky unexpected result (21)
Stable unexpected results that are known to be intermittent (12)
|
✨ Try run (#8293298728) succeeded. |
mrobinson
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me and it doesn't seem to change test results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only tell users to install gstreamer plugins base/bad, so if you install only what we ask, you won’t be able to play webm videos with av1.
This patch adds the good and ugly plugins to all of our dependency lists, including in the README and mach bootstrap. I have also updated the deps for all of the Linux distros on the wiki.
./mach build -d
does not report any errors./mach test-tidy
does not report any errors