Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RUSTC env to clippy command #31694

Merged
merged 2 commits into from Mar 15, 2024
Merged

Add RUSTC env to clippy command #31694

merged 2 commits into from Mar 15, 2024

Conversation

eerii
Copy link
Contributor

@eerii eerii commented Mar 15, 2024 •
edited

Adds the env override directly to the ./mach cargo-clippy command so we can run it without RUSTC=rustc.

Once merged: Update the description of #31500 removing RUSTC=rustc.

@eerii eerii marked this pull request as ready for review March 15, 2024 10:59
@mrobinson mrobinson added this pull request to the merge queue Mar 15, 2024
Merged via the queue into servo:main with commit cb3ae70 Mar 15, 2024
9 checks passed
@eerii eerii deleted the clippy_env branch March 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagudev sagudev sagudev left review comments

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crown should be disabled when running cargo clippy.
3 participants
@eerii @mrobinson @sagudev