Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pseudo async Create*PipelineAsync methods #31695

Merged
merged 3 commits into from Mar 19, 2024

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Mar 15, 2024

Renewed #31194

It also includes WebGPU CTS update to gpuweb/cts@ad066ef with a lot of stabilization:


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes in CTS

@sagudev sagudev added the T-webgpu Do a try run on Linux of the WebGPU CTS label Mar 15, 2024
@github-actions github-actions bot removed the T-webgpu Do a try run on Linux of the WebGPU CTS label Mar 15, 2024
Copy link

🔨 Triggering try run (#8295983938) for WebGPU CTS

Copy link

Test results for linux-wpt-layout-2020 from try job (#8295983938):

Flaky unexpected result (25)
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,af_comparison:less_than:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,af_multiplication:vector_scalar:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f16_remainder:scalar_vector:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_matrix_subtraction:matrix:*
  • CRASH [expected TIMEOUT] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_matrix_vector_multiplication:matrix_vector:*
  • CRASH [expected TIMEOUT] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_matrix_vector_multiplication:vector_matrix:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_multiplication:scalar_compound:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_remainder:scalar:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_subtraction:scalar:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,u32_arithmetic:addition_scalar_vector:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,u32_arithmetic:division_vector_scalar:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,asin:f32:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,atan:abstract_float:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,cos:f32:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,dot:abstract_int:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,max:abstract_int:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,min:f16:*
  • CRASH [expected TIMEOUT] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,mix:f32_nonmatching_vec2:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,sinh:f16:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,smoothstep:f32:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,tan:abstract_float:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,tanh:f16:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,unpack4x8snorm:unpack:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,unary,f16_conversion:f32_mat:*
  • CRASH [expected TIMEOUT] /_webgpu/webgpu/webgpu/web_platform/reftests/canvas_image_rendering.https.html
Stable unexpected results (8)
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_multiplication:vector_scalar:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,f32_subtraction:scalar_compound:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,i32_arithmetic:multiplication_vector_scalar:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,ceil:abstract_float:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,exp2:f32:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,length:f16_vec4:*
  • CRASH [expected ERROR] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,reflect:f32_vec4:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,transpose:f16:*

Copy link

⚠️ Try run (#8295983938) failed.

@sagudev
Copy link
Member Author

sagudev commented Mar 17, 2024

Test results for linux-wpt-layout-2020 from try job (#8295983938):
Flaky unexpected result (25)
Stable unexpected results (8)

As noted in PR summary all fails (except one flake) are webgpu:shader,execution,expression and I think this is as good as it gets, for now.

Copy link
Member

@gterzian gterzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOM methods stubs LGTM. I didn't look at the test changes(the actual changes to test code),why are those necessary?

@sagudev
Copy link
Member Author

sagudev commented Mar 19, 2024

I didn't look at the test changes(the actual changes to test code),why are those necessary?

Thoes are actually coming from upstream (some things were needed for stabilization of results).

@sagudev sagudev added this pull request to the merge queue Mar 19, 2024
Merged via the queue into servo:main with commit c250691 Mar 19, 2024
33 of 38 checks passed
@sagudev sagudev deleted the create-pipeline-fake-async branch March 19, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants