Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix warnings in components/script #31700

Merged
merged 3 commits into from Mar 15, 2024
Merged

clippy: Fix warnings in components/script #31700

merged 3 commits into from Mar 15, 2024

Conversation

richarddushime
Copy link
Contributor

@richarddushime richarddushime commented Mar 15, 2024 •
edited by mrobinson

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500.
  • These changes do not require tests because they do not modify functionality, they only fix lint errors

@richarddushime
Copy link
Contributor Author

Hi @mrobinson
Hope you are well
i m requesting for a review on this
I would like to push more of such fixes over the weekend if I get a review and suggest changes to know if I'm in the right way
Thank you

@mrobinson mrobinson changed the title Fix clippy warnings in components/script/ clippy: Fix warnings in components/script Mar 15, 2024
@mrobinson mrobinson added this pull request to the merge queue Mar 15, 2024
Merged via the queue into servo:main with commit 8a6481c Mar 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richarddushime @mrobinson