Pick the first or last baseline as appropriate #31705

Loirooriol · 2024-03-15T19:25:14Z

The old logic was always picking the last baseline, but this should only happen for inline-blocks.

Since replaced elements and flex containers aren't currently setting their baselines, this is only an improvement for inline-tables.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Baseline alignment of inline-tables is broken, especially if anonymous #31651
There are tests for these changes

github-actions · 2024-03-15T19:29:47Z

🔨 Triggering try run (#8301349534) for Linux WPT

github-actions · 2024-03-15T20:45:01Z

Test results for linux-wpt-layout-2020 from try job (#8301349534):

Flaky unexpected result (16)

FAIL [expected PASS] /_mozilla/mozilla/iframe/resize_after_load.html (#13573)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected PASS] /css/css-color/animation/opacity-animation-ending-correctly-002.html (#29216)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy same-site destination
```
Test timed out
```
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Cross-site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected NOTRUN] subtest: sec-fetch-site - Same site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Same-Origin -> Cross-Site -> Same-Origin redirect, no attributes
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- PASS [expected FAIL] subtest: <a> tag navigate fails for unparseable URLs
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-nonexistent.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with non-existent fragments should work.
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Area element should support autofocus
```
Test timed out
```
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in name (formdata event)
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

Stable unexpected results that are known to be intermittent (19)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
CRASH [expected PASS] /_mozilla/css/img_dynamic_remove.html (#16115)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
PASS [expected FAIL] /css/CSS2/text/white-space-pre-002.xht (#21909)
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-animation.html (#21930)
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-paragraph.html (#21930)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460'
- PASS [expected FAIL] subtest: Matching font-stretch: '90%' should prefer '90% 100%' over '50% 80%'
- PASS [expected FAIL] subtest: Matching font-stretch: '90%' should prefer '60% 70%' over '110% 140%'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 20deg' over 'oblique 10deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 10deg' over 'italic'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 10deg' should prefer 'italic' over 'oblique 0deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg'
FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#31559)

OK /css/cssom-view/elementsFromPoint-iframes.html (#19273)

FAIL [expected PASS] subtest: elementsFromPoint on inner documents

assert_equals: document.getElementById('iframe').contentDocument.elementsFromPoint(1,1) expected "DIV#div, BODY, HTML" but got "DIV#div, BODY, HTML, IFRAME#iframe, BODY, HTML, HTML"

OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿĀ" but got ""
```
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked
```
assert_equals: expected "😍" but got ""
```
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "\ufffdA" but got ""
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
Test timed out
```
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load

OK [expected TIMEOUT]

/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html

(#25805)

FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise

assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"

FAIL [expected TIMEOUT] subtest: Rejection handler on pending-then-rejected promise

assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"

Stable unexpected results (7)

FAIL [expected PASS] /css/CSS2/borders/border-left-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-left-color-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-left-width-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-right-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-right-color-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-right-width-applies-to-014.xht
PASS [expected FAIL] /css/CSS2/normal-flow/inline-table-002b.xht

github-actions · 2024-03-15T20:45:40Z

⚠️ Try run (#8301349534) failed.

mrobinson · 2024-03-16T08:43:50Z

I'm curious which tests will start passing, so I've done a rebase of this change via the GitHub interface.

github-actions · 2024-03-16T08:49:23Z

🔨 Triggering try run (#8306605201) for Linux WPT

github-actions · 2024-03-16T09:34:46Z

Test results for linux-wpt-layout-2020 from try job (#8306605201):

Flaky unexpected result (19)

OK /_mozilla/css/stylesheet_media_queries.html (#17159)
- FAIL [expected PASS] subtest: Media queries within stylesheets
```
assert_equals: expected "rgb(0, 255, 0)" but got "rgb(255, 0, 0)"
```
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Cross-site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Same site, no attributes
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/about-srcdoc-navigation-blocked.window.html (#31025)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- PASS [expected FAIL] subtest: <a> tag navigate fails for unparseable URLs
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
CRASH [expected FAIL] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
OK /resource-timing/status-codes-create-entry.html (#28675)
- PASS [expected FAIL] subtest: Make sure all status codes are reported
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 11083008 but got 11082752
```
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

Stable unexpected results that are known to be intermittent (21)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
PASS [expected FAIL] /css/CSS2/text/white-space-pre-002.xht (#21909)
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-animation.html (#21930)
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-paragraph.html (#21930)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460'
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '450 460' over '500'
- PASS [expected FAIL] subtest: Matching font-stretch: '90%' should prefer '60% 70%' over '110% 140%'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique -20deg' over 'oblique -60deg -40deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique -60deg -40deg' over 'oblique -10deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique 0deg' over 'oblique 30deg 60deg'

OK /css/cssom-view/elementsFromPoint-iframes.html (#19273)

FAIL [expected PASS] subtest: elementsFromPoint on inner documents

assert_equals: document.getElementById('iframe').contentDocument.elementsFromPoint(1,1) expected "DIV#div, BODY, HTML" but got "DIV#div, BODY, HTML, IFRAME#iframe, BODY, HTML, HTML"

OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- PASS [expected FAIL] subtest: Smooth scrolling while doing history navigation.
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
```
Test timed out
```
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- PASS [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
TIMEOUT [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
CRASH [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out
```
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-valid.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with URL fragments should be skipped.
```
assert_true: expected true got false
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task

OK [expected TIMEOUT]

/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html

(#25805)

FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise

assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"

FAIL [expected TIMEOUT] subtest: Rejection handler on pending-then-rejected promise

assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"

TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 18981632 but got 18981888
```

Stable unexpected results (6)

FAIL [expected PASS] /css/CSS2/borders/border-left-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-left-color-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-left-width-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-right-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-right-color-applies-to-014.xht
FAIL [expected PASS] /css/CSS2/borders/border-right-width-applies-to-014.xht

github-actions · 2024-03-16T09:34:56Z

⚠️ Try run (#8306605201) failed.

Loirooriol · 2024-03-17T22:02:05Z

The failures are due to #31722.

servo-wpt-sync · 2024-03-22T20:10:45Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#45287) with upstreamable changes.

github-actions · 2024-03-22T20:11:33Z

🔨 Triggering try run (#8395896326) for Linux WPT

servo-wpt-sync · 2024-03-22T20:12:17Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#45287) title and body.

servo-wpt-sync · 2024-03-22T20:13:01Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#45287).

github-actions · 2024-03-22T20:51:47Z

Test results for linux-wpt-layout-2020 from try job (#8395896326):

Flaky unexpected result (19)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '450 460' over '500'
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '390 410' over '300 350'
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '350 399' over '340 360'
- PASS [expected FAIL] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%'
- PASS [expected FAIL] subtest: Matching font-stretch: '110%' should prefer '110% 120%' over '115% 116%'
- PASS [expected FAIL] subtest: Matching font-stretch: '90%' should prefer '60% 70%' over '110% 140%'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique -20deg' over 'oblique -60deg -40deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique -10deg' over 'italic'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'italic' over 'oblique 0deg'
PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-user-activation.tentative.sub.window.html (#31729)
- TIMEOUT [expected FAIL] subtest: Allow top with user activation + user activation
```
Test timed out
```
- NOTRUN [expected PASS] subtest: allow-top-navigation-by-user-activation set but no sticky activation
OK /html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode.html (#21666)
- PASS [expected FAIL] subtest: <img srcset="/images/green-1x1.png?e38 50w, /images/green-16x16.png?e38 51w" sizes="(min-width:calc(0)) 1px"> ref sizes="1px" (quirks mode)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: single quote in value (normal form)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```

Stable unexpected results that are known to be intermittent (18)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-cross-site.tentative.sub.window.html (#31754)
- TIMEOUT [expected FAIL] subtest: A same-site unsandboxed iframe navigation does not consume user activation and allows top-level navigation.
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: A same-site unsandboxed iframe navigation without sticky user activation does not allow top-level navigation.
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

github-actions · 2024-03-22T20:52:02Z

Test results for linux-wpt-layout-2013 from try job (#8395896326):

Flaky unexpected result (21)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test

OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)

FAIL [expected PASS] subtest: [data-expected-height] 1

assert_equals: 
&lt;inline-block data-expected-height="10"&gt;123 &lt;span style="margin-left: -8ch"&gt;1234 &lt;/span&gt;&lt;/inline-block&gt;
height expected 10 but got 20

FAIL [expected PASS] subtest: [data-expected-height] 2

assert_equals: 
&lt;inline-block data-expected-height="10"&gt;123 &lt;span style="margin-left: -8ch"&gt;123 &lt;/span&gt;&lt;/inline-block&gt;
height expected 10 but got 20

PASS [expected FAIL] subtest: [data-expected-height] 4

TIMEOUT [expected OK] /css/css-flexbox/abspos/position-absolute-013.html (#28405)
OK /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
- FAIL [expected PASS] subtest: addEventListener "once" option is respected
```
assert_equals: expected 1 but got 0
```
TIMEOUT [expected OK] /custom-elements/reactions/customized-builtins/HTMLMediaElement.html (#31014)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- PASS [expected FAIL] subtest: <a> tag navigate fails for unparseable URLs
TIMEOUT [expected OK] /html/browsers/history/the-history-interface/traverse-during-unload.html (#28688)
- TIMEOUT [expected PASS] subtest: Traversing the history during unload
```
Test timed out
```
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/skip-another-top-level-browsing-context.html (#24161)
- TIMEOUT [expected PASS] subtest: Autofocus elements queued in another top-level browsing context's documents should be skipped.
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: \r\n in name (normal form)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: \r\n in value (formdata event)
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- TIMEOUT [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
```
Test timed out
```
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk
```
assert_equals: expected (string) "text/html" but got (undefined) undefined
```
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk
```
Test timed out
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (14)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected FAIL] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)
PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Area element should support autofocus
```
Test timed out
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
Test timed out
```
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 5697536 but got 5697280
```
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

github-actions · 2024-03-22T20:52:14Z

✨ Try run (#8395896326) succeeded.

The old logic was always picking the last baseline, but this should only happen for inline-blocks. Since replaced elements and flex containers aren't currently setting their baselines, this is only an improvement for inline-tables.

servo-wpt-sync · 2024-03-25T14:27:04Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#45287).

The old logic was always picking the last baseline, but this should only happen for inline-blocks. Since replaced elements and flex containers aren't currently setting their baselines, this is only an improvement for inline-tables.

Loirooriol added A-layout/inline A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 T-linux-wpt-2020 Do a try run of the WPT labels Mar 15, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Mar 15, 2024

mrobinson force-pushed the pick-first-or-last-baseline branch from 06f631f to 681e638 Compare March 16, 2024 08:43

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Mar 16, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Mar 16, 2024

Loirooriol force-pushed the pick-first-or-last-baseline branch from 681e638 to 43e8919 Compare March 22, 2024 20:08

servo-wpt-sync mentioned this pull request Mar 22, 2024

Pick the first or last baseline as appropriate web-platform-tests/wpt#45287

Merged

Loirooriol force-pushed the pick-first-or-last-baseline branch from 43e8919 to 16ef6ff Compare March 22, 2024 20:10

Loirooriol added T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Mar 22, 2024

github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Mar 22, 2024

Loirooriol marked this pull request as ready for review March 22, 2024 23:50

Loirooriol requested a review from mrobinson March 22, 2024 23:52

Pick the first or last baseline as appropriate

4b9cbe2

The old logic was always picking the last baseline, but this should only happen for inline-blocks. Since replaced elements and flex containers aren't currently setting their baselines, this is only an improvement for inline-tables.

mrobinson approved these changes Mar 25, 2024

View reviewed changes

Loirooriol force-pushed the pick-first-or-last-baseline branch from 16ef6ff to 4b9cbe2 Compare March 25, 2024 14:23

Loirooriol enabled auto-merge March 25, 2024 14:25

Loirooriol added this pull request to the merge queue Mar 25, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2024

Loirooriol added this pull request to the merge queue Mar 25, 2024

Merged via the queue into servo:main with commit e77dc36 Mar 25, 2024
9 checks passed

Loirooriol deleted the pick-first-or-last-baseline branch March 25, 2024 17:22

Loirooriol mentioned this pull request Mar 26, 2024

Implement baseline-source #31875

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pick the first or last baseline as appropriate #31705

Pick the first or last baseline as appropriate #31705

Loirooriol commented Mar 15, 2024 •

edited

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

mrobinson commented Mar 16, 2024

github-actions bot commented Mar 16, 2024

github-actions bot commented Mar 16, 2024

github-actions bot commented Mar 16, 2024

Loirooriol commented Mar 17, 2024

servo-wpt-sync commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

servo-wpt-sync commented Mar 22, 2024

servo-wpt-sync commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

servo-wpt-sync commented Mar 25, 2024

Pick the first or last baseline as appropriate #31705

Pick the first or last baseline as appropriate #31705

Conversation

Loirooriol commented Mar 15, 2024 • edited

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

mrobinson commented Mar 16, 2024

github-actions bot commented Mar 16, 2024

github-actions bot commented Mar 16, 2024

github-actions bot commented Mar 16, 2024

Loirooriol commented Mar 17, 2024

servo-wpt-sync commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

servo-wpt-sync commented Mar 22, 2024

servo-wpt-sync commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

servo-wpt-sync commented Mar 25, 2024

Loirooriol commented Mar 15, 2024 •

edited