rustdoc: Fix warning in components/layout_2020
#31708
Conversation
|
Sorry, I didn't see this before I added my own pr. I resolved some of the broken references differently. See #31712. |
components/layout_2020/flow/line.rs
Outdated
| @@ -32,7 +32,7 @@ use crate::style_ext::PaddingBorderMargin; | |||
| use crate::ContainingBlock; | |||
|
|
|||
| pub(super) struct LineMetrics { | |||
| /// The block offset of the line start in the containing [`InlineFormattingContext`]. | |||
| /// The block offset of the line start in the containing Inline Formatting Context. | |||
There was a problem hiding this comment.
I think you can just qualify the reference to InlineFormattingContext instead of removing the link.
| @@ -59,7 +59,7 @@ pub(crate) enum NonReplacedFormattingContextContents { | |||
| // Other layout modes go here | |||
| } | |||
|
|
|||
| /// The baselines of a layout or a [`BoxFragment`]. Some layout uses the first and some layout uses | |||
| /// The baselines of a layout or [`Fragment::Box`] Some layout uses the first and some layout uses | |||
There was a problem hiding this comment.
Again, I think this just needs to be qualified. Fragment::Box is an enum variant, but this is actually referring to the struct stored inside the enum variant BoxFragment.
|
@mrobinson I think that third edit that @Aaryakhandelwal suggested seems to be accurate. She changed [ |
|
@mrobinson , Am I still supposed to make changes, as the next PR created by @Rhea-Eve already handles these both errors correctly. |
Let's land both PRs. I suggest just updating this PR to remove the first two changes. |
mrobinson
changed the title
components/layout_2020
Yes, I will do that |
mrobinson
force-pushed
the
FixRustDocErrors
branch
from
854c3ce
to
99560c2
Compare
Fixed the unresolved links present in components/layout_2020
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors