clippy: Fix many warnings in components/script
#31717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
requested changes
Mar 17, 2024
Comment on lines
4387
to
4390
| return { | ||
| self.webgl_error(InvalidEnum); | ||
| Ok(()) | ||
| }; |
There was a problem hiding this comment.
It feels like this should be spit up into two statements instead of putting multiple statements in a block after return. Please make this change here and other place the same pattern is repeated.
There was a problem hiding this comment.
Suggested change
| return { | |
| self.webgl_error(InvalidEnum); | |
| Ok(()) | |
| }; | |
| self.webgl_error(InvalidEnum); | |
| return Ok(()); |
components/script/dom/videotrack.rs
Outdated
Comment on lines
38
to
41
| id: id, | ||
| kind: kind, | ||
| label: label, | ||
| language: language, |
There was a problem hiding this comment.
Can this just be the following?
id,
kind,
label,
language,There was a problem hiding this comment.
You resolved the conversation, but you didn't answer the question here. Can these simply be replaced by what I've written above?
mrobinson
changed the title
components/script
|
It looks like there is a build failure here. |
|
When checking the box that says "./mach build -d does not report any errors" please make sure that you've actually tried building this change locally. |
Surely, I have it built locally , let me repeat the process and i will add a screenshot |
|
Here are the build error from the Linux job (linked below): |
See my screen below |
|
Let me finish the suggested changes and i push them. |
@richarddushime, instead of posting screenshots, please paste console output into a code block like I've done above. Once you make changes, you'll need to run |
Rebuilding Now |
Got the same build error locally after updating main and current branche |
richarddushime
force-pushed
the
clippywarnings
branch
from
2684c52
to
264c27d
Compare
|
@richarddushime You don't need to press the "Update branch" button. I only recommend updating against main if there are merge conflicts and in that case it is better to do a manual rebase than to press the button. The reason is that every time you press the button, GitHub will create a merge commit which adds noise to the PR. |
Thanks for this I have just realized the Noise it's causing |
mrobinson
requested changes
Mar 19, 2024
components/script/dom/videotrack.rs
Outdated
Comment on lines
38
to
41
| id: id, | ||
| kind: kind, | ||
| label: label, | ||
| language: language, |
There was a problem hiding this comment.
You resolved the conversation, but you didn't answer the question here. Can these simply be replaced by what I've written above?
Comment on lines
4387
to
4390
| return { | ||
| self.webgl_error(InvalidEnum); | ||
| Ok(()) | ||
| }; |
There was a problem hiding this comment.
Suggested change
| return { | |
| self.webgl_error(InvalidEnum); | |
| Ok(()) | |
| }; | |
| self.webgl_error(InvalidEnum); | |
| return Ok(()); |
Comment on lines
+4425
to
+4426
| return { | ||
| self.webgl_error(InvalidOperation); | ||
| Ok(()) | ||
| }; |
There was a problem hiding this comment.
Suggested change
| return { | |
| self.webgl_error(InvalidOperation); | |
| Ok(()) | |
| }; | |
| self.webgl_error(InvalidOperation); | |
| return Ok(()); |
Comment on lines
+4431
to
+4432
| return { | ||
| self.webgl_error(InvalidOperation); | ||
| Ok(()) | ||
| }; |
There was a problem hiding this comment.
Suggested change
| return { | |
| self.webgl_error(InvalidOperation); | |
| Ok(()) | |
| }; | |
| self.webgl_error(InvalidOperation); | |
| return Ok(()); |
Comment on lines
+4528
to
+4529
| return { | ||
| self.webgl_error(InvalidOperation); | ||
| Ok(()) | ||
| }; |
There was a problem hiding this comment.
Suggested change
| return { | |
| self.webgl_error(InvalidOperation); | |
| Ok(()) | |
| }; | |
| self.webgl_error(InvalidOperation); | |
| return Ok(()); |
|
🔨 Triggering try run (#8344312267) for Linux WPT |
mrobinson
force-pushed
the
clippywarnings
branch
from
fa83315
to
27d7e50
Compare
mrobinson
approved these changes
Mar 19, 2024
I m actually building and then running it and I m going to make a final commit I m sorry for delaying it's taking time |
No worries. I've fixed the errors in a new commit. Please don't push any more commits to your branch as that may delay the landing of this change. |
|
Test results for linux-wpt-layout-2020 from try job (#8344312267): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (20)
|
|
|
auto-merge was automatically disabled
March 19, 2024 15:24
Head branch was pushed to by a user without write access
oops just seen this now and I have ready made a commit |
|
@mrobinson just made a final fix of everything is well now Hopefully |
mrobinson
approved these changes
Mar 19, 2024
No worries. I have sent this back to the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors