rustdoc: Fix broken link to FontFace in components/gfx
#31745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
requested changes
Mar 18, 2024
Comment on lines
84
to
86
| /// | ||
| /// [`FontFace`]: https://developer.mozilla.org/en-US/docs/Web/API/FontFace | ||
| /// |
There was a problem hiding this comment.
This isn't the FontFace that's referred to here. You can just use dwrote::FontFace, I think.
There was a problem hiding this comment.
Actually, the issue here is that the method is returning Font, but I had written FontFace when I added this documentation because it changed while refactoring.
There was a problem hiding this comment.
Got it. Thanks for letting me know.
mrobinson
changed the title
FontFace in components/gfx
mrobinson
approved these changes
Mar 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the MDN documentation link referenced in the rustwasm doc to resolve the
FontFacebroken link warning../mach build -ddoes not report any errors./mach test-tidydoes not report any errors