Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx: Derive line-through metrics for fonts on MacOS #31756

Merged
merged 1 commit into from
Mar 19, 2024

Commits on Mar 19, 2024

  1. gfx: Derive line-through metrics for fonts on MacOS

    There is now platform-specific way to get metrics for `line-through` on
    MacOS and currently striking through simply does not work. The correct
    approach here is likely to first search for these metrics in font tables
    and then falling back to deriving them. Searching the font tables is a
    larger change, so this change adds the fallback mechanism first. This at
    least makes sure that strike through renders at all on Mac.
    
    In a followup change we can add support for getting metrics via HarfBuzz
    in a platform-independent way, which is what Gecko does.
    
    Fixes servo#942.
    mrobinson committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    bc64f94 View commit details
    Browse the repository at this point in the history