clippy: Fix some clippy problems in components/script
#31778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
requested changes
Mar 20, 2024
components/script/task_queue.rs
Outdated
| @@ -237,16 +237,16 @@ impl<T: QueuedTaskConversion> TaskQueue<T> { | |||
| // Reduce the length of throttles, | |||
| // but don't add the task to "msg_queue", | |||
| // and neither increment "taken_task_counter". | |||
| throttled_length = throttled_length - 1; | |||
| throttled_length - 1; | |||
There was a problem hiding this comment.
This was assigning throttled_length to throttled_length - 1, but now this statement does nothing.
components/script/task_queue.rs
Outdated
| self.taken_task_counter | ||
| .set(self.taken_task_counter.get() + 1); | ||
| throttled_length = throttled_length - 1; | ||
| throttled_length - 1; |
There was a problem hiding this comment.
The same situation seems to be happening here.
mrobinson
requested changes
Mar 20, 2024
components/script/task_queue.rs
Outdated
| @@ -237,7 +237,7 @@ impl<T: QueuedTaskConversion> TaskQueue<T> { | |||
| // Reduce the length of throttles, | |||
| // but don't add the task to "msg_queue", | |||
| // and neither increment "taken_task_counter". | |||
| throttled_length - 1; | |||
| throttled_length - =1; | |||
There was a problem hiding this comment.
Please run ./mach fmt before uploading changes.
Suggested change
| throttled_length - =1; | |
| throttled_length - =1; |
mrobinson
changed the title
components/script
Yes sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors