Fix WPT reference no_red_3x3_monospace_table-ref.xht #31802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#45241) with upstreamable changes. |
Loirooriol
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8373008170) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8373008170): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (23)
|
|
Test results for linux-wpt-layout-2013 from try job (#8373008170): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (14)
|
|
✨ Try run (#8373008170) succeeded. |
mrobinson
requested changes
Mar 21, 2024
ports/servoshell/minibrowser.rs
Outdated
| @@ -7,7 +7,7 @@ use std::num::NonZeroU32; | |||
| use std::sync::Arc; | |||
| use std::time::Instant; | |||
|
|
|||
| use egui::{CentralPanel, Frame, InnerResponse, Key, Modifiers, PaintCallback, TopBottomPanel}; | |||
| use egui::{CentralPanel, Frame, Key, Modifiers, PaintCallback, TopBottomPanel}; | |||
There was a problem hiding this comment.
Please remove this unrelated change.
There was a problem hiding this comment.
on my end : current branch its not there
There was a problem hiding this comment.
its only available on the main branch
once merged , i hope it will fix it
There was a problem hiding this comment.
You need to rebase your change onto the main branch:
git checkout main
git pull
git checkout wptreference
git rebase -i main
Do the interactive rebase and then make sure that when you do git diff main wptreference the change is not there.
There was a problem hiding this comment.
Or I can simply rebase from the PR, I guess. I'll do that now.
There was a problem hiding this comment.
Great
Thanks
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#45241). |
Loirooriol
approved these changes
Mar 21, 2024
mrobinson
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the Guidelines i made the necessary changes and checked all tests As requested in the issue #31752
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors