Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Fix needless_borrow warnings in components/script #31813

Merged

Conversation

oluwatobiss
Copy link
Contributor

@oluwatobiss oluwatobiss commented Mar 21, 2024

This PR fixes the needless_borrow warnings by deleting the address of operations (&), which the compiler will dereferenced immediately.

ref: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they only resolve clippy warnings. They do not change functionalities.

@mrobinson
Copy link
Member

The strategy of doing these one type of error at a time makes these much easier to review. Thank you!

@mrobinson mrobinson added this pull request to the merge queue Mar 21, 2024
Merged via the queue into servo:main with commit 3e63f8d Mar 21, 2024
10 checks passed
@oluwatobiss oluwatobiss deleted the clippy/fix-needless-borrow-warnings branch March 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants