Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix explicit_auto_deref warnings in components/script #31837

Merged
merged 5 commits into from Mar 23, 2024
Merged

clippy: Fix explicit_auto_deref warnings in components/script #31837

merged 5 commits into from Mar 23, 2024

Conversation

oluwatobiss
Copy link
Contributor

@oluwatobiss oluwatobiss commented Mar 23, 2024 •
edited by mrobinson

Remove dereferencings to fix the explicit_auto_deref warnings.

ref: https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they only resolve clippy warnings. They do not change functionalities.

@mrobinson mrobinson added this pull request to the merge queue Mar 23, 2024
Merged via the queue into servo:main with commit 3c05b58 Mar 23, 2024
10 checks passed
@oluwatobiss oluwatobiss deleted the clippy/fix-explicit-auto-deref-warnings branch March 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oluwatobiss @mrobinson