New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run platform bootstrap first in bootstrap #31840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause a problem on unsupported Linux distributions, as it prevents the installation of crown
and taplo
.
c899e49
to
df64d83
Compare
We only need to do this on windows. |
Hrm. Thinking out loud here, maybe the order shouldn't be so important when running code in |
Warning for unsupported Linux distributions, right? |
Yep, exactly. Perhaps this should just warn and allow continuing, rather than simply exiting and skipping the installation of taplo and crown. |
178a2f6
to
e8c0a61
Compare
It would be nice if that also happened on windows. For example, I was quite happy that the |
So the user do not need to install llvm via choco manually. This should solve
error: linker lld-link.exe not found
error on windows../mach build -d
does not report any errors./mach test-tidy
does not report any errors