Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix collapsible_if warnings in components/script #31852

Merged
merged 2 commits into from Mar 25, 2024
Merged

clippy: Fix collapsible_if warnings in components/script #31852

merged 2 commits into from Mar 25, 2024

Conversation

oluwatobiss
Copy link
Contributor

@oluwatobiss oluwatobiss commented Mar 25, 2024 •
edited by mrobinson

Collapse the nested if statements using && to combine their conditions, thus fixing the collapsible_if warnings.

ref: https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they only resolve clippy warnings. They do not change functionalities.

@mrobinson mrobinson added this pull request to the merge queue Mar 25, 2024
Merged via the queue into servo:main with commit a53632c Mar 25, 2024
10 checks passed
ektuu pushed a commit to ektuu/servo that referenced this pull request Mar 25, 2024
@oluwatobiss @ektuu
clippy: Fix collapsible_if warnings (servo#31852)
5bbff9e
@oluwatobiss oluwatobiss deleted the clippy/fix-collapsible-if-warnings branch March 26, 2024 16:32
ektuu pushed a commit to ektuu/servo that referenced this pull request Mar 28, 2024
@oluwatobiss @ektuu
clippy: Fix collapsible_if warnings (servo#31852)
e4dcbed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oluwatobiss @mrobinson