Fix table with rows but no column #31862

Loirooriol · 2024-03-25T18:17:25Z

We weren't generating any fragment for the rows, which meant that JS APIs like clientWidth would be 0, and also outlines weren't painted.

This aligns Servo with Blink and WebKit. Gecko is broken, it distributes twice the table height among the rows.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

We weren't generating any fragment for the rows, which meant that JS APIs like clientWidth would be 0, and also outlines weren't painted. This aligns Servo with Blink and WebKit. Gecko is broken, it distributes twice the table height among the rows.

servo-wpt-sync · 2024-03-25T18:22:58Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#45319) with upstreamable changes.

github-actions · 2024-03-25T18:30:15Z

🔨 Triggering try run (#8424990204) for Linux WPT

github-actions · 2024-03-25T19:32:39Z

Test results for linux-wpt-layout-2013 from try job (#8424990204):

Flaky unexpected result (14)

TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /css/css-flexbox/abspos/position-absolute-013.html (#28405)
PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
OK [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- FAIL [expected TIMEOUT] subtest: opener of discarded auxiliary browsing context
```
assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: \r\n in name (normal form)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
OK /html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html (#27659)
- FAIL [expected PASS] subtest: async document.write in a module
```
assert_true: onload must be called expected true got false
```
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
OK /xhr/open-url-multi-window-5.htm (#23360)
- FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)
```
assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw
```

Stable unexpected results that are known to be intermittent (12)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: border-image sec-fetch-user - Not sent to non-trustworthy same-site destination
```
assert_unreached: Reached unreachable code
```
- PASS [expected FAIL] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```

github-actions · 2024-03-25T19:32:46Z

Test results for linux-wpt-layout-2020 from try job (#8424990204):

Flaky unexpected result (23)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
CRASH [expected PASS] /_webgl/conformance/glsl/bugs/nested-functions-should-not-crash.html (#30680)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '500' should prefer '351 398' over '501 550'
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '400' over '450 460'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 10deg' should prefer 'oblique -50deg -20deg' over 'oblique -40deg -30deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -10deg' should prefer 'oblique -60deg -30deg' over 'oblique -50deg -40deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique -60deg -40deg' over 'oblique -10deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique -10deg' over 'italic'
PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- FAIL [expected PASS] subtest: looks up handleEvent method on every event dispatch
```
assert_equals: expected 2 but got 1
```
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
OK /css/cssom-view/MediaQueryList-change-event-matches-value.html (#27973)
- FAIL [expected PASS] subtest: MediaQueryList.changed is correct for all lists in the document even during a change event handler
```
assert_equals: Should've fired the change event in both MediaQueryLists expected 2 but got 0
```
TIMEOUT /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
- FAIL [expected PASS] subtest: onchange adds listener
```
promise_test: Unhandled rejection with value: object "TypeError: _event is undefined"
```
TIMEOUT [expected OK] /custom-elements/reactions/customized-builtins/HTMLMediaElement.html (#31014)
TIMEOUT /fetch/api/basic/keepalive.any.html (#29536)
- TIMEOUT [expected PASS] subtest: [keepalive] simple GET request on 'load' [no payload]; setting up
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: [keepalive] simple GET request on 'pagehide' [no payload]; setting up
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/about-srcdoc-navigation-blocked.window.html (#31025)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿĀ" but got ""
```
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked
```
assert_equals: expected "😍" but got ""
```
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "\ufffdA" but got ""
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk
```
assert_equals: expected (string) "text/html" but got (undefined) undefined
```
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk
```
Test timed out
```
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 15821824 but got 15821568
```
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- FAIL [expected PASS] subtest: Verifies that location navigations take precedence when following form submissions.
```
assert_equals: expected "/html/semantics/forms/form-submission-0/resources/location.html" but got "/html/semantics/forms/form-submission-0/resources/form.html"
```
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```

github-actions · 2024-03-25T19:52:20Z

✨ Try run (#8424990204) succeeded.

mrobinson

Looks good to me with one small suggestion:

components/layout_2020/table/layout.rs

servo-wpt-sync · 2024-03-26T11:05:34Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#45319).

servo-wpt-sync · 2024-03-26T11:56:06Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

* Fix table with rows but no column We weren't generating any fragment for the rows, which meant that JS APIs like clientWidth would be 0, and also outlines weren't painted. This aligns Servo with Blink and WebKit. Gecko is broken, it distributes twice the table height among the rows. * Feedback * Avoid conflict with servo#31874

Fix table with rows but no column

527ff7d

We weren't generating any fragment for the rows, which meant that JS APIs like clientWidth would be 0, and also outlines weren't painted. This aligns Servo with Blink and WebKit. Gecko is broken, it distributes twice the table height among the rows.

Loirooriol added A-layout/table A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Mar 25, 2024

Loirooriol mentioned this pull request Mar 25, 2024

[css2][css-tables] Width of row that span 0 columns? w3c/csswg-drafts#10132

Open

servo-wpt-sync mentioned this pull request Mar 25, 2024

Fix table with rows but no column web-platform-tests/wpt#45319

Merged

github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Mar 25, 2024

Loirooriol marked this pull request as ready for review March 26, 2024 10:26

Loirooriol requested a review from mrobinson March 26, 2024 10:26

mrobinson approved these changes Mar 26, 2024

View reviewed changes

components/layout_2020/table/layout.rs Outdated Show resolved Hide resolved

Feedback

eef7944

Loirooriol added this pull request to the merge queue Mar 26, 2024

Avoid conflict with servo#31874

ba34cf0

Loirooriol removed this pull request from the merge queue due to a manual request Mar 26, 2024

Loirooriol enabled auto-merge March 26, 2024 11:55

Loirooriol added this pull request to the merge queue Mar 26, 2024

Merged via the queue into servo:main with commit d16f259 Mar 26, 2024
9 checks passed

Loirooriol deleted the fix-row-with-0-columns branch March 26, 2024 14:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix table with rows but no column #31862

Fix table with rows but no column #31862

Loirooriol commented Mar 25, 2024

servo-wpt-sync commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

mrobinson left a comment

servo-wpt-sync commented Mar 26, 2024

servo-wpt-sync commented Mar 26, 2024

Fix table with rows but no column #31862

Fix table with rows but no column #31862

Conversation

Loirooriol commented Mar 25, 2024

servo-wpt-sync commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

mrobinson left a comment

Choose a reason for hiding this comment

servo-wpt-sync commented Mar 26, 2024

servo-wpt-sync commented Mar 26, 2024