clippy: Fix clone_on_copy warnings in components/script
#31877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
approved these changes
Mar 26, 2024
mrobinson
force-pushed
the
clippy/fix-clone-on-copy-warnings
branch
from
34a6a1b
to
d718b1e
Compare
|
Thanks @oluwatobiss. I've added this to the merge queue. You should not need to use the "Update branch" button any more. |
|
Great. Thank you! |
ektuu
pushed a commit
to ektuu/servo
that referenced
this pull request
Mar 28, 2024
MunishMummadi
pushed a commit
to MunishMummadi/servo
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
clone()calls onCopytypes to fix theclone_on_copywarnings.ref: https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors