compositing: Send entire scene's scroll offsets when sending WebRender display lists #31892

mrobinson · 2024-03-27T11:12:40Z

WebRender does not preserve spatial tree offsets when updating the
spatial tree. Updating the spatial tree of a pipeline can also
update the spatial tree of child pipelines. This change ensures that
WebRender always gets the scroll offsets of the entire scene when
modifying display lists in a way that may rebuild the spatial tree.

Fixes #31807.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Scroll offsets are sometimes lost when updating WebRender display list #31807.
There are tests for these changes

github-actions · 2024-03-27T11:21:23Z

🔨 Triggering try run (#8450928277) for Linux WPT, MacOS, Windows, Android

github-actions · 2024-03-27T12:15:19Z

Test results for linux-wpt-layout-2020 from try job (#8450928277):

Flaky unexpected result (29)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works.
```
Test timed out
```
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
FAIL [expected PASS] /_mozilla/mozilla/iframe/resize_after_load.html (#13573)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected PASS] /css/CSS2/floats/line-pushed-by-floats-crash.html
TIMEOUT [expected PASS] /css/css-animations/crashtests/replace-keyframes-animating-filter-001.html
TIMEOUT [expected PASS] /css/css-backgrounds/linear-gradient-calc-crash.html
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-stretch: '110%' should prefer '105%' over '100%'
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'normal' over 'oblique 0deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 20deg' should prefer 'italic' over 'oblique 0deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 21deg' over 'oblique 30deg 60deg'
TIMEOUT [expected PASS] /css/css-text/white-space/pre-line-br-with-whitespace-child-crash.html
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
OK /css/cssom-view/matchMedia.html (#31428)
- PASS [expected FAIL] subtest: iframe.matchMedia("(width: 200px)") matches
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- PASS [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
OK [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- FAIL [expected TIMEOUT] subtest: opener of discarded auxiliary browsing context
```
assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"
```
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK /html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-quirks-mode.html (#21666)
- PASS [expected FAIL] subtest: <img srcset="/images/green-1x1.png?e38 50w, /images/green-16x16.png?e38 51w" sizes="(min-width:calc(0)) 1px"> ref sizes="1px" (quirks mode)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: \r\n in value (normal form)
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: character not in encoding in filename (formdata event)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- TIMEOUT [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
```
Test timed out
```
CRASH [expected OK] /url/failure.html (#28574)
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

Stable unexpected results that are known to be intermittent (17)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK [expected TIMEOUT] /css/css-flexbox/abspos/position-absolute-013.html (#28405)
PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

github-actions · 2024-03-27T12:15:55Z

Test results for linux-wpt-layout-2013 from try job (#8450928277):

Flaky unexpected result (27)

CRASH [expected OK] /_mozilla/mozilla/service-workers/service-worker-registration.https.html (#31036)
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected PASS] /css/CSS2/floats/floats-saturated-position-crash.html
TIMEOUT [expected PASS] /css/CSS2/linebox/crashtests/dir-change-simplifed-crash.html (#31451)
TIMEOUT [expected PASS] /css/css-fonts/font-size-adjust-reload.html (#30678)
PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
TIMEOUT [expected PASS] /css/css-tables/crashtests/empty_cells_crash.html
TIMEOUT [expected PASS] /css/css-text/crashtests/rendering-table-caption-with-list-item-and-svg-crash.html
TIMEOUT [expected PASS] /css/css-text/white-space/text-wrap-balance-narrow-crash.html
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- FAIL [expected PASS] subtest: listeners are called correct number of times
```
assert_equals: expected 4 but got 3
```
TIMEOUT [expected PASS] /css/filter-effects/backdrop-filter-feimage-crash.html
TIMEOUT [expected PASS] /css/selectors/pseudo-where-crash.html
TIMEOUT [expected PASS] /dom/xslt/strip-space-crash.xml
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
CRASH [expected OK] /html/browsers/browsing-the-web/unloading-documents/prompt-and-unload-script-closeable.html
TIMEOUT [expected OK] /html/browsers/history/the-history-interface/traverse_the_history_write_onload_1.html (#21581)
- TIMEOUT [expected PASS] subtest: Traverse the history when a history entry is written in the load event
```
Test timed out
```
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: non-ASCII in name and value (formdata event)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise
```
Test timed out
```
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk
```
assert_equals: expected (string) "text/html" but got (undefined) undefined
```
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)
TIMEOUT [expected OK] /workers/same-site-cookies/first-party.default.tentative.https.window.html
- TIMEOUT [expected FAIL] subtest: Check SharedWorker sameSiteCookies option default for first-party
```
Test timed out
```

Stable unexpected results that are known to be intermittent (11)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: border-image sec-fetch-dest - Not sent to non-trustworthy same-site destination
```
assert_unreached: Reached unreachable code
```
- PASS [expected FAIL] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- TIMEOUT [expected FAIL] subtest: origin referrer policy used to create the starting page
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

github-actions · 2024-03-27T12:21:08Z

✨ Try run (#8450928277) succeeded.

mrobinson · 2024-03-27T14:20:57Z

Hey @delan, just let me know if you'd like me to hold off on this one until you've landed #31417.

delan · 2024-03-28T05:11:18Z

Hey @delan, just let me know if you'd like me to hold off on this one until you've landed #31417.

Go ahead, I probably won’t be able to land my patch until Monday anyway.

delan

The impl looks good, but can we have an automated test for this?

…r display lists WebRender does not preserve spatial tree offsets when updating the spatial tree. Updating the spatial tree of a pipeline can also update the spatial tree of child pipelines. This change ensures that WebRender always gets the scroll offsets of the entire scene when modifying display lists in a way that may rebuild the spatial tree. Fixes servo#31807.

mrobinson · 2024-03-29T08:57:11Z

The impl looks good, but can we have an automated test for this?

At first I didn't think so, but after a bit of pondering it turns out that there is a way to test this. I've added that test to the latest version of the branch.

servo-wpt-sync · 2024-03-29T08:58:17Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#45425) with upstreamable changes.

mrobinson added the T-full Do a full try run label Mar 27, 2024

github-actions bot removed the T-full Do a full try run label Mar 27, 2024

mrobinson requested a review from delan March 27, 2024 14:18

delan reviewed Mar 28, 2024

View reviewed changes

mrobinson force-pushed the always-send-all-scroll-offsets branch from cd7d32f to dba60f1 Compare March 29, 2024 08:56

servo-wpt-sync mentioned this pull request Mar 29, 2024

compositing: Send entire scene's scroll offsets when sending WebRender display lists web-platform-tests/wpt#45425

Merged

delan self-requested a review April 3, 2024 04:29

delan approved these changes Apr 3, 2024

View reviewed changes

mrobinson added this pull request to the merge queue Apr 3, 2024

Merged via the queue into servo:main with commit 8aaff61 Apr 3, 2024
10 checks passed

mrobinson deleted the always-send-all-scroll-offsets branch April 3, 2024 07:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compositing: Send entire scene's scroll offsets when sending WebRender display lists #31892

compositing: Send entire scene's scroll offsets when sending WebRender display lists #31892

mrobinson commented Mar 27, 2024 •

edited

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

mrobinson commented Mar 27, 2024

delan commented Mar 28, 2024

delan left a comment

mrobinson commented Mar 29, 2024

servo-wpt-sync commented Mar 29, 2024

compositing: Send entire scene's scroll offsets when sending WebRender display lists #31892

compositing: Send entire scene's scroll offsets when sending WebRender display lists #31892

Conversation

mrobinson commented Mar 27, 2024 • edited

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

mrobinson commented Mar 27, 2024

delan commented Mar 28, 2024

delan left a comment

Choose a reason for hiding this comment

mrobinson commented Mar 29, 2024

servo-wpt-sync commented Mar 29, 2024

mrobinson commented Mar 27, 2024 •

edited