Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Remove let bindings in components/script/dom #31908

Merged
merged 1 commit into from Mar 27, 2024

Conversation

azharcodeit
Copy link
Contributor

@azharcodeit azharcodeit commented Mar 27, 2024

Omitted all of the let bindings with unit values across the files in components/script/dom

https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
e.g:
Screenshot 2024-03-27 at 19 36 18


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they do not affect functionality

@mrobinson mrobinson changed the title clippy: omitted the let bindings in components/script/dom clippy: Remove let bindings in components/script/dom Mar 27, 2024
@mrobinson mrobinson added this pull request to the merge queue Mar 27, 2024
Merged via the queue into servo:main with commit ff95ce5 Mar 27, 2024
12 checks passed
@azharcodeit azharcodeit deleted the fix/cargo-clippy-warnings branch March 27, 2024 22:43
ektuu pushed a commit to ektuu/servo that referenced this pull request Mar 28, 2024
MunishMummadi pushed a commit to MunishMummadi/servo that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants