Fixed some clippy warnings in components

[jahielkomu]

This PR fixes some clippy warnings by;

• Removing unused lifetimes
• Simplifying boolean expressions
• Removing useless use of format!
• Replacing the use Option.and_then() with .map()
• Replacing the call of Option.map().flatten() with .and_then()

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes are part of Fix as many clippy problems as possible #31500
• These changes do not require tests because it doesn't touch functionality.

[jahielkomu]

Hello @mrobinson
Please kindly review.
Thanks.

[jahielkomu]

@mrobinson , a lot of the warnings talk about the use of unsafe code, should we use #[allow(unsafe_code)] ?
Kindly advise.

[mrobinson]

Hrm...I think this new formulation is more difficult to understand. In this case, I would add an exception for the clippy warning or rewrite the logic to be more understandable.

[jahielkomu]

I absolutely agree with you @mrobinson ...I picked this straight from the clippy suggestion and felt it was more complicated but thought it was the standard. I checked that it evaluated to the same as the before and applied it.
Let me find another way for this sir.
Thank you.

[mrobinson]

I feel the same way about this new code.

[jahielkomu]

Let me work on it sir

[jahielkomu]

I have updated the PR @mrobinson , kindly review again.

[jahielkomu]

Hmm something seems to not be going fine sir @mrobinson .
Is it due to the changes made in the PR?
./mach test-unit, ./mach test-tidy and ./mach build -d ran with no errors.
Let me rerun them perhaps

->They are running with no errors.

[jahielkomu]

@mrobinson , a lot of the warnings talk about the use of unsafe code, should we use #[allow(unsafe_code)] ? Kindly advise.

Sir would you recommend this?

[mrobinson]

@mrobinson , a lot of the warnings talk about the use of unsafe code, should we use #[allow(unsafe_code)] ? Kindly advise.

Adding allow(unsafe_code) shouldn't be necessary, as it's absence would cause a compilation error. I think it would be helpful to see the actual error messages that you are referring to in the clippy warnings. If they are the ones regarding the missing "# Safety" section in the documentation, the fix is to write that documentation. That requires a bit of understanding and care though, as we want the documentation to actually reflect the real safety requirements of those functions.