New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat indefinite percentages as auto for margin collapse #32059
Merged
Loirooriol
merged 1 commit into
servo:main
from
Loirooriol:collapse-thru-indefinite-percentages
Apr 12, 2024
Merged
Treat indefinite percentages as auto for margin collapse #32059
Loirooriol
merged 1 commit into
servo:main
from
Loirooriol:collapse-thru-indefinite-percentages
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
added
A-layout/2020
https://github.com/servo/servo/wiki/Layout-2020
T-linux-wpt-2020
Do a try run of the WPT
labels
Apr 11, 2024
🔨 Triggering try run (#8651561510) for Linux WPT |
Test results for linux-wpt-layout-2020 from try job (#8651561510): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (9)
Stable unexpected results (1)
|
Loirooriol
force-pushed
the
collapse-thru-indefinite-percentages
branch
from
April 11, 2024 19:23
86fc370
to
bc01452
Compare
|
mrobinson
approved these changes
Apr 12, 2024
The top and bottom margins of an element can collapse through if its height is auto or zero. Indefinite percentages behave as auto, so they shouldn't prevent the margins from collapsing. Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Loirooriol
force-pushed
the
collapse-thru-indefinite-percentages
branch
from
April 12, 2024 11:45
bc01452
to
45abcfe
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top and bottom margins of an element can collapse through if its height is auto or zero. Indefinite percentages behave as auto, so they shouldn't prevent the margins from collapsing.
./mach build -d
does not report any errors./mach test-tidy
does not report any errors