script_layout: Remove script to layout messages #32081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#8690595859) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2020 from try job (#8690595859): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (12)
|
|
Test results for linux-wpt-layout-2013 from try job (#8690595859): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (9)
|
|
|
mrobinson
force-pushed
the
remove-script-to-layout-messages
branch
from
7de4bb1
to
e8d7d0e
Compare
mukilan
approved these changes
Apr 22, 2024
| @@ -466,7 +466,7 @@ pub enum InputMethodType { | |||
| } | |||
|
|
|||
| #[derive(Clone, Copy, Debug, Deserialize, Serialize)] | |||
| /// The equivalent of script_layout_interface::message::Msg | |||
| /// The equivalent of script_layout_interface::Msg | |||
There was a problem hiding this comment.
Msg is removed in this patch, so wouldn't this comment be incorrect? I guess this enum is now unused and can be deleted along with the HangAnnotation::Layout variant. I'm fine if you think that can happen in a separate patch.
There was a problem hiding this comment.
You're right. I wasn't sure if these would be used again someday, but I think we should remove them now because they are dead code.
Thanks so much for the review!
Instead of communicating with layout via messages, script can simply call methods on the layout trait. This simplifies the way that script communicates with layout and opens the path to sharing more data structures between the two systems.
mrobinson
force-pushed
the
remove-script-to-layout-messages
branch
from
e8d7d0e
to
675df5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of communicating with layout via messages, script can simply
call methods on the layout trait. This simplifies the way that script
communicates with layout and opens the path to sharing more data
structures between the two systems. This is part of a continuing
series of cleanups after removing the layout thread.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors