Simplify FontHandle and rename it to PlatformFont
#32101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
force-pushed
the
clean-up-font-handle
branch
2 times, most recently
from
84342a2
to
0bbd6e3
Compare
Rename it to `PlatformFont` and move the `FontTemplate` member to `Font`, because it's shared by all platforms.
mrobinson
force-pushed
the
clean-up-font-handle
branch
from
0bbd6e3
to
f8467a8
Compare
mukilan
approved these changes
Apr 17, 2024
Co-authored-by: Mukilan Thiyagarajan <mukilanthiagarajan@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename it to
PlatformFontand move theFontTemplatemember toFont, because it's shared by all platforms../mach build -ddoes not report any errors./mach test-tidydoes not report any errors