Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix map_flatten warning in components/script #32110

Merged
merged 2 commits into from
Apr 18, 2024
Merged

clippy: Fix map_flatten warning in components/script #32110

merged 2 commits into from
Apr 18, 2024

Conversation

oluwatobiss
Copy link
Contributor

  • Replace .map().flatten() call with .and_then() to fix the map_flatten warning.
  • Update functions' comments from plain to rustdoc syntax.
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Fix as many clippy problems as possible #31500
  • These changes do not require tests because they only resolve clippy warnings. They do not change functionalities.

mukilan
mukilan approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@mukilan mukilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mukilan mukilan added this pull request to the merge queue Apr 18, 2024
Merged via the queue into servo:main with commit 2a96711 Apr 18, 2024
9 checks passed
@oluwatobiss oluwatobiss deleted the clippy/fix-map-flatten-warning branch April 18, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukilan mukilan mukilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix as many clippy problems as possible
2 participants
@oluwatobiss @mukilan