Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgpu: Update to wgpu 0.20 #32173

Merged
merged 5 commits into from May 8, 2024
Merged

webgpu: Update to wgpu 0.20 #32173

merged 5 commits into from May 8, 2024

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Apr 29, 2024 •
edited

The only real change is Transmute trait that got removed from wgpu (and left us without queue_id->device_id) transmute so I added it back, others are actually provided by wgpu.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes in WebGPU CTS

@sagudev
Copy link
Member Author

sagudev commented May 1, 2024

try run: https://github.com/sagudev/servo/actions/runs/8895986601/job/24429950022

CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:api,validation,encoding,beginRenderPass:depth_stencil_attachment,device_mismatch:* is also reproducible on firefox, issue opened upstream: gfx-rs/wgpu#5628

@sagudev sagudev marked this pull request as ready for review May 3, 2024 06:26
@sagudev sagudev requested a review from gterzian May 3, 2024 06:27
@sagudev sagudev added the A-content/webgpu The WebGPU implementation. label May 3, 2024
@sagudev sagudev changed the title Update to wgpu 0.20 webgpu: Update to wgpu 0.20 May 3, 2024
@sagudev sagudev mentioned this pull request May 3, 2024
Open
gterzian
gterzian approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@gterzian gterzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one question.

components/webgpu/lib.rs Show resolved Hide resolved
@sagudev sagudev enabled auto-merge May 8, 2024 05:16
@sagudev sagudev added this pull request to the merge queue May 8, 2024
Merged via the queue into servo:main with commit c4f8599 May 8, 2024
9 checks passed
@sagudev sagudev deleted the wgpu020 branch May 8, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gterzian gterzian gterzian approved these changes

Assignees
No one assigned
Labels
A-content/webgpu The WebGPU implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sagudev @gterzian