layout: use Au in BoxFragment
#32349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#9196209058) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2013 from try job (#9196209058): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (10)
|
|
Test results for linux-wpt-layout-2020 from try job (#9196209058): Flaky unexpected result (8)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (5)
|
|
|
mrobinson
changed the title
au in box_fragementAu in box_fragement
|
🔨 Triggering try run (#9209851487) for Linux WPT |
atbrakhi
commented
May 23, 2024
| let list = &self.style.get_box().transform; | ||
| match list.to_transform_3d_matrix(Some(containing_block)) { | ||
| match list.to_transform_3d_matrix(Some(&au_rect_to_length_rect(containing_block))) { |
There was a problem hiding this comment.
I had to a convert here because it is expected to be ComputedType as can be noticed here. It was trickier to keep &Rect<Length> as it was!
same of calculate_transform_matrix in this same file!
There was a problem hiding this comment.
Yeah, this makes sense I think. Transforms use f32.
|
Test results for linux-wpt-layout-2020 from try job (#9209851487): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (2)
|
|
|
mrobinson
requested changes
May 24, 2024
atbrakhi
force-pushed
the
physical_rect
branch
3 times, most recently
from
16a746c
to
3c1467f
Compare
|
🔨 Triggering try run (#9365574631) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#9365574631): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (2)
|
|
|
Loirooriol
requested changes
Jun 10, 2024
Comment on lines
128
to
139
| let physical_rect = euclid::default::Rect::new( | ||
| euclid::default::Point2D::new( | ||
| Au::from_f32_px(rect.origin.x.to_f32_px()), | ||
| Au::from_f32_px(rect.origin.y.to_f32_px()), | ||
| ), | ||
| euclid::default::Size2D::new( | ||
| Au::from_f32_px(rect.size.width.to_f32_px()), | ||
| Au::from_f32_px(rect.size.height.to_f32_px()), | ||
| ), | ||
| ); | ||
|
|
||
| content_boxes.push(physical_rect); |
There was a problem hiding this comment.
I think this is equivalent:
Suggested change
| let physical_rect = euclid::default::Rect::new( | |
| euclid::default::Point2D::new( | |
| Au::from_f32_px(rect.origin.x.to_f32_px()), | |
| Au::from_f32_px(rect.origin.y.to_f32_px()), | |
| ), | |
| euclid::default::Size2D::new( | |
| Au::from_f32_px(rect.size.width.to_f32_px()), | |
| Au::from_f32_px(rect.size.height.to_f32_px()), | |
| ), | |
| ); | |
| content_boxes.push(physical_rect); | |
| content_boxes.push(rect.to_untyped()); |
There was a problem hiding this comment.
Thanks, I didn't know about to_untyped(). Looks very helpful.
|
There is also the "fragement" typo in the issue title and description |
mrobinson
changed the title
Au in box_fragementAu in BoxFragment
|
🔨 Triggering try run (#9489484091) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2020 from try job (#9489484091): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (11)
Stable unexpected results (1)
|
|
Test results for linux-wpt-layout-2013 from try job (#9489484091): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (7)
Stable unexpected results (1)
|
|
|
Loirooriol
reviewed
Jun 13, 2024
|
🔨 Triggering try run (#9497848844) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#9497848844): Flaky unexpected result (9)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (6)
|
|
|
|
🔨 Triggering try run (#9501088006) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#9501088006): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (9)
Stable unexpected results (1)
|
|
|
|
🔨 Triggering try run (#9502276872) for Linux WPT |
Loirooriol
reviewed
Jun 13, 2024
Comment on lines
+10
to
+21
|
|
||
| [clientWidth, offsetWidth and scrollWidth round 5.5 to 6] | ||
| expected: FAIL | ||
|
|
||
| [clientWidth, offsetWidth and scrollWidth round 5.9 to 6] | ||
| expected: FAIL | ||
|
|
||
| [clientHeight, offsetHeight and scrollHeight round 5.5 to 6] | ||
| expected: FAIL | ||
|
|
||
| [clientHeight, offsetHeight and scrollHeight round 5.9 to 6] | ||
| expected: FAIL |
There was a problem hiding this comment.
I don't think this should be failing. Was it passing before my suggestions?
There was a problem hiding this comment.
No, it was also failing before your suggestion
|
Test results for linux-wpt-layout-2020 from try job (#9502276872): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#9502276872) succeeded. |
mrobinson
approved these changes
Jun 17, 2024
Comment on lines
+1831
to
+1832
| let row_group_start_corner: LogicalVec2<Au> = row_group_layout.rect.start_corner; | ||
| self.rect.start_corner -= row_group_start_corner; |
There was a problem hiding this comment.
Suggested change
| let row_group_start_corner: LogicalVec2<Au> = row_group_layout.rect.start_corner; | |
| self.rect.start_corner -= row_group_start_corner; | |
| self.rect.start_corner -= row_group_layout.rect.start_corner; |
| @@ -711,7 +712,7 @@ impl<'a> BuilderForBoxFragment<'a> { | |||
| // is used). | |||
| if let BackgroundMode::Extra(ref extra_backgrounds) = self.fragment.background_mode { | |||
| for extra_background in extra_backgrounds { | |||
| let positioning_area: LogicalRect<Length> = extra_background.rect.clone().into(); | |||
| let positioning_area: LogicalRect<Au> = extra_background.rect.clone(); | |||
There was a problem hiding this comment.
Suggested change
| let positioning_area: LogicalRect<Au> = extra_background.rect.clone(); | |
| let positioning_area = extra_background.rect.clone(); |
| @@ -1209,7 +1209,7 @@ impl SequentialLayoutState { | |||
| ); | |||
|
|
|||
| let pbm_sums = &(&box_fragment.padding + &box_fragment.border) + &box_fragment.margin; | |||
| let content_rect: LogicalRect<Au> = box_fragment.content_rect.clone().into(); | |||
| let content_rect: LogicalRect<Au> = box_fragment.content_rect.clone(); | |||
There was a problem hiding this comment.
Suggested change
| let content_rect: LogicalRect<Au> = box_fragment.content_rect.clone(); | |
| let content_rect = box_fragment.content_rect.clone(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use app units in
BoxFragment,fragment_treeand at some other places in layout2020./mach build -ddoes not report any errors./mach test-tidydoes not report any errors