-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement outerText on HtmlElement #32427
base: main
Are you sure you want to change the base?
Conversation
🔨 Triggering try run (#9336273957) for Linux WPT |
Test results for linux-wpt-layout-2020 from try job (#9336273957): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (6)
|
Test results for linux-wpt-layout-2013 from try job (#9336273957): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (9)
Stable unexpected results (1)
|
|
040778b
to
4b9f364
Compare
🔨 Triggering try run (#9355115686) for Linux WPT |
Test results for linux-wpt-layout-2020 from try job (#9355115686): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (7)
|
Test results for linux-wpt-layout-2013 from try job (#9355115686): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (9)
|
✨ Try run (#9355115686) succeeded. |
97abfd9
to
9c46420
Compare
@shanehandley Any reason this was closed? I had it on my todo list to review this. |
Hi @mrobinson, apologies for not leaving a comment, I have been tapping away trying to improve the WPT passes for it over the past 2 weeks, but have not made much progress at all 😬. Though if you are happy to provide feedback, I'd be very grateful 🙏 Thank you! |
9c46420
to
e35c8ac
Compare
e35c8ac
to
b8a50ae
Compare
Apply CSS text rules where available Account for whitespace collapsing that deviates from normal processing
b8a50ae
to
b352ad4
Compare
Implements the IDL attribute / behaviour for
outerText
as well as some basic layout code.I haven't previously made any changes to anything related to layout code, so I thought I should check to ensure that I am not going in the wrong direction.
Cheers!
./mach build -d
does not report any errors./mach test-tidy
does not report any errors