fonts: Respect emoji variation selector when selecting fonts #32493

mrobinson · 2024-06-14T08:35:33Z

This uses a pretty simple heuristic to select a font likely to contain
color emoji. In the future Servo should actually check if the font also
contains a color representation of the character in question. For now
the code assumes that when a font supports color glyphs of some kind and
supports the character in question at all, it supports the color
version.

This fixes support for rendering keycap emoji clusters such as 1️⃣ .

Co-authored-by: Rakhi Sharma atbrakhi@igalia.com
Co-authored-by: Mukilan Thiyagarajan mukilan@igalia.com
Signed-off-by: Martin Robinson mrobinson@igalia.com

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes are part of insufficient font fallback handling fails to render cjk glyphs (and other glyphs) #17267.
These changes do not require tests because emoji rendering is quite hard to test, but we verified that this improves the "emoji-list.html" manual test.

mrobinson · 2024-06-14T09:17:14Z

Hrm...there seems to be some kind of problem with this on macOS. I'm investigating now...

mrobinson · 2024-06-14T10:17:07Z

Now that we are selecting fonts based on the emoji presentation needs, this change revealed an issue where we were too readily choosing emoji presentation. Instead of requesting it for every possible emoji character in the absence of an explicit emoji variation selection, we should only do it for characters that have an emoji presentation themselves.

For example, "0" is classified as an "emoji character" by unicode_properties because it might be used in an emoji sequence, but it does not have an emoji presentation unless followed by the emoji variation selector. '😅' is both an emoji character and has an emoji presentation, so it doesn't need to be followed by a variation selector to require the emoji font.

github-actions · 2024-06-14T12:49:29Z

🔨 Triggering try run (#9516395313) for Linux WPT

github-actions · 2024-06-14T13:31:17Z

Test results for linux-wpt-layout-2020 from try job (#9516395313):

Flaky unexpected result (16)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
CRASH [expected PASS] /_mozilla/mozilla/webgl/tex_image_2d_canvas2d.html

OK /css/css-fonts/variations/font-weight-matching.html

FAIL [expected PASS] subtest: Test @font-face matching for weight 470

assert_approx_equals: @font-face should be mapped to CSSTest Weights 300. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 500

assert_approx_equals: @font-face should be mapped to CSSTest Weights 300. expected 90 +/- 2 but got 180

OK /css/css-values/calc-in-media-queries-with-mixed-units.html (#31731)
- FAIL [expected PASS] subtest: box should be orange if the calc between vh+px in @media was correct
```
assert_equals: expected "rgb(255, 165, 0)" but got "rgb(0, 0, 255)"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿĀ" but got ""
```
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked
```
assert_equals: expected "😍" but got ""
```
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "\ufffdA" but got ""
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/interaction/focus/the-autofocus-attribute/document-with-fragment-valid.html (#28259)
- PASS [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with URL fragments should be skipped.
TIMEOUT [expected OK] /html/semantics/document-metadata/the-base-element/base_target_does_not_affect_location_assignment.html
- TIMEOUT [expected PASS] subtest: base_target_does_not_affect_location_assignment
```
Test timed out
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK /html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html (#27659)
- PASS [expected FAIL] subtest: async document.write in a module
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 18549504 but got 18549760
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

Stable unexpected results that are known to be intermittent (11)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
TIMEOUT [expected OK] /css/css-transitions/disconnected-element-001.html (#32275)
- TIMEOUT [expected PASS] subtest: Transitions are canceled when an element is re-parented to the same node
```
Test timed out
```
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- TIMEOUT [expected FAIL] subtest: sec-fetch-site - Cross-site, no attributes
```
Test timed out
```
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html (#25046)
- NOTRUN [expected PASS] subtest: calling play() on a sufficiently long audio should trigger timeupdate event
- NOTRUN [expected PASS] subtest: calling play() on a sufficiently long video should trigger timeupdate event
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-cross-site.tentative.sub.window.html (#31754)
- FAIL [expected TIMEOUT] subtest: A cross-site unsandboxed iframe navigation consumes user activation and disallows top-level navigation.
```
promise_test: Unhandled rejection with value: object "TypeError: element.scrollIntoView is not a function"
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 6209024 but got 6209280
```

Stable unexpected results (1)

PASS [expected FAIL] /css/css-text/text-transform/text-transform-capitalize-026.html

github-actions · 2024-06-14T13:34:35Z

Test results for linux-wpt-layout-2013 from try job (#9516395313):

Flaky unexpected result (12)

PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
CRASH [expected OK] /fetch/private-network-access/mixed-content-fetch.tentative.https.window.html
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿĀ" but got ""
```
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked
```
assert_equals: expected "😍" but got ""
```
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "\ufffdA" but got ""
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.html
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk
```
assert_equals: expected (string) "text/html" but got (undefined) undefined
```
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk
```
Test timed out
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- FAIL [expected PASS] subtest: Test sending a message after closing.
```
assert_not_equals: got disallowed value "pong"
```

Stable unexpected results that are known to be intermittent (6)

OK /_mozilla/mozilla/detached_layout.html (#32343)
- FAIL [expected PASS] subtest: Detached layout doesn't panic
```
uncaught exception: Error: assert_equals: rectangle should be zero-sized expected 0 but got 284
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
```
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
```
- FAIL [expected NOTRUN] subtest: Area element should support autofocus
```
promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
```
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in filename (formdata event)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)

Stable unexpected results (7)

FAIL [expected PASS] /css/css-tables/visibility-collapse-border-spacing-001.html
FAIL [expected PASS] /css/css-tables/visibility-collapse-border-spacing-002.html
OK /url/IdnaTestV2.window.html
- PASS [expected FAIL] subtest: ToASCII("a‌b") C1
- PASS [expected FAIL] subtest: ToASCII("A‌B") C1
- PASS [expected FAIL] subtest: ToASCII("A‌b") C1
- PASS [expected FAIL] subtest: ToASCII("xn--ab-j1t") C1
- PASS [expected FAIL] subtest: ToASCII("a‍b") C2
- PASS [expected FAIL] subtest: ToASCII("A‍B") C2
- PASS [expected FAIL] subtest: ToASCII("A‍b") C2
- PASS [expected FAIL] subtest: ToASCII("xn--ab-m1t") C2
- PASS [expected FAIL] subtest: ToASCII("1.aß‌‍b‌‍cßßßßdςσßßßßßßßßeßßßßßßßßßßxßßßßßßßßßßyßßßßßßßß̂ßz") C1; C2; A4_2 (ignored)
- PASS [expected FAIL] subtest: ToASCII("1.ASS‌‍B‌‍CSSSSSSSSDΣΣSSSSSSSSSSSSSSSSESSSSSSSSSSSSSSSSSSSSXSSSSSSSSSSSSSSSSSSSSYSSSSSSSSSSSSSSSŜSSZ") C1; C2; A4_2 (ignored)
- And 164 more unexpected results...
OK /url/toascii.window.html
- PASS [expected FAIL] subtest: ‍.example (using URL)
- PASS [expected FAIL] subtest: ‍.example (using URL.host)
- PASS [expected FAIL] subtest: ‍.example (using URL.hostname)
- PASS [expected FAIL] subtest: ‍.example (using <a>)
- PASS [expected FAIL] subtest: ‍.example (using <a>.host)
- PASS [expected FAIL] subtest: ‍.example (using <a>.hostname)
- PASS [expected FAIL] subtest: xn--1ug.example (using URL)
- PASS [expected FAIL] subtest: xn--1ug.example (using URL.host)
- PASS [expected FAIL] subtest: xn--1ug.example (using URL.hostname)
- PASS [expected FAIL] subtest: xn--1ug.example (using <a>)
- And 2 more unexpected results...
OK /url/url-setters-a-area.window.html?exclude=(file|javascript|mailto)
- PASS [expected FAIL] subtest: <a>: Setting <foo://somehost/some/path>.pathname = '' Non-special URLs can have their paths erased
OK /url/url-setters.any.html?exclude=(file|javascript|mailto)
- PASS [expected FAIL] subtest: URL: Setting <foo://somehost/some/path>.pathname = '' Non-special URLs can have their paths erased
OK /url/url-setters.any.worker.html?exclude=(file|javascript|mailto)
- PASS [expected FAIL] subtest: URL: Setting <foo://somehost/some/path>.pathname = '' Non-special URLs can have their paths erased

github-actions · 2024-06-14T13:34:46Z

⚠️ Try run (#9516395313) failed.

github-actions · 2024-06-14T14:17:06Z

🔨 Triggering try run (#9517614268) for Linux WPT

mrobinson · 2024-06-14T14:18:27Z

I've had to modify this a bit. Now this explicitly handles characters that are emoji, but without emoji presentation, such as '☺'. These kind of characters should explicitly avoid emoji-like fonts unless they are paired with an emoji variation selector.

mrobinson · 2024-06-14T14:19:24Z

I have chosen to add a new mode EmojiPresentationPreference::None as well to avoid expensive lookups of tables when it shouldn't matter what the presentation is for the character.

github-actions · 2024-06-14T14:55:57Z

Test results for linux-wpt-layout-2020 from try job (#9517614268):

Flaky unexpected result (15)

CRASH [expected PASS] /_webgl/conformance/glsl/bugs/temp-expressions-should-not-crash.html (#22050)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 10deg 40deg' over 'oblique 20deg 30deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 0deg' should prefer 'oblique 5deg' over 'oblique 15deg 20deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
TIMEOUT [expected OK] /css/css-transitions/disconnected-element-001.html (#32275)
- TIMEOUT [expected PASS] subtest: Transitions are canceled when an element is re-parented
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Transitions are canceled when an element is re-parented to the same node
TIMEOUT [expected OK] /css/css-transitions/non-rendered-element-002.html (#32338)
- TIMEOUT [expected PASS] subtest: Transitions on ::before/::after pseudo-elements are canceled when the content property is cleared
```
Test timed out
```

OK /css/css-values/cap-invalidation.html

FAIL [expected PASS] subtest: CSS Values and Units Test: cap invalidation

uncaught exception: Error: assert_not_equals: expect the capital height of Ahem and sans-serif to be different got disallowed value 371.3333333333333

OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - name is missing
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy cross-site destination
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿĀ" but got ""
```
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked
```
assert_equals: expected "😍" but got ""
```
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "\ufffdA" but got ""
```

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-user-activation-sticky.tentative.sub.window.html (#32154)
- TIMEOUT [expected FAIL] subtest: Allow top with user activation + user activation
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: single quote in name (formdata event)
- PASS [expected FAIL] subtest: multipart/form-data: single quote in value (normal form)
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk
```
assert_equals: expected (string) "text/html" but got (undefined) undefined
```
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk
```
Test timed out
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- TIMEOUT [expected FAIL] subtest: sec-fetch-site - Cross-site, no attributes
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
OK [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-cross-site.tentative.sub.window.html (#31754)
- FAIL [expected TIMEOUT] subtest: A cross-site unsandboxed iframe navigation consumes user activation and disallows top-level navigation.
```
promise_test: Unhandled rejection with value: object "TypeError: element.scrollIntoView is not a function"
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (formdata event)
- PASS [expected FAIL] subtest: text/plain: 0x00 in name (formdata event)
OK /html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html (#27659)
- PASS [expected FAIL] subtest: async document.write in a module
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

github-actions · 2024-06-14T14:56:10Z

✨ Try run (#9517614268) succeeded.

mrobinson · 2024-06-17T08:21:28Z

I'll go ahead and land this one. There are some changes since the last review, these are mostly minor.

This uses a pretty simple heuristic to select a font likely to contain color emoji. In the future Servo should actually check if the font also contains a color representation of the character in question. For now the code assumes that when a font supports color glyphs of some kind and supports the character in question at all, it supports the color version. This fixes support for rendering keycap emoji clusters such as 1️⃣ . Co-authored-by: Rakhi Sharma <atbrakhi@igalia.com> Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>

mrobinson requested review from mukilan and atbrakhi June 14, 2024 08:37

mukilan approved these changes Jun 14, 2024

View reviewed changes

mukilan added this pull request to the merge queue Jun 14, 2024

mrobinson removed this pull request from the merge queue due to a manual request Jun 14, 2024

mrobinson force-pushed the emoji-presentation branch from 7667053 to 6657aaf Compare June 14, 2024 10:14

mrobinson enabled auto-merge June 14, 2024 10:31

mrobinson added this pull request to the merge queue Jun 14, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 14, 2024

mrobinson force-pushed the emoji-presentation branch from 6657aaf to a8fbf36 Compare June 14, 2024 12:44

mrobinson added T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Jun 14, 2024

github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Jun 14, 2024

mrobinson force-pushed the emoji-presentation branch from a8fbf36 to 60bea62 Compare June 14, 2024 14:14

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Jun 14, 2024

mrobinson requested a review from mukilan June 14, 2024 14:16

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Jun 14, 2024

mrobinson added this pull request to the merge queue Jun 17, 2024

mukilan approved these changes Jun 17, 2024

View reviewed changes

atbrakhi approved these changes Jun 17, 2024

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024

mrobinson force-pushed the emoji-presentation branch from 60bea62 to 4c8e758 Compare June 17, 2024 09:36

mukilan added this pull request to the merge queue Jun 18, 2024

Merged via the queue into servo:main with commit 57b64d8 Jun 18, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fonts: Respect emoji variation selector when selecting fonts #32493

fonts: Respect emoji variation selector when selecting fonts #32493

mrobinson commented Jun 14, 2024 •

edited

Loading

mrobinson commented Jun 14, 2024

mrobinson commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

mrobinson commented Jun 14, 2024

mrobinson commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

mrobinson commented Jun 17, 2024

fonts: Respect emoji variation selector when selecting fonts #32493

fonts: Respect emoji variation selector when selecting fonts #32493

Conversation

mrobinson commented Jun 14, 2024 • edited Loading

mrobinson commented Jun 14, 2024

mrobinson commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

mrobinson commented Jun 14, 2024

mrobinson commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

mrobinson commented Jun 17, 2024

mrobinson commented Jun 14, 2024 •

edited

Loading