Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android build on Fedora 40. #32532

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Commits on Jun 17, 2024

  1. Fix android build on Fedora 40.

    * Postfix PATH with android toolchain:
      We only need to edit path for the linker specified
      in the `.cargo/config.toml` to be found. Adding the
      NDK clang to the end of PATH is sufficient for that.
      Adding the NDK clang to the front can cause problems
      however, since it causes the NDK `clang` to be
      preferred over the system clang. This can cause
      problems on some systems, where compiling
      e.g. buildscripts for HOST subsequently fails.
    * Prefix target compiler and compiler flags variables
      with `TARGET_` so as not to influence compilation
      for HOST targets.
     * SET `CLANG_PATH` to avoid [bindgen servo#2682]
    
     [bindgen servo#2682]: rust-lang/rust-bindgen#2682
    
    Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
    jschwe committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9e1f0e8 View commit details
    Browse the repository at this point in the history