Move simpleservo_jni into servoshell #32533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow-up to: #32532 |
jschwe
changed the title
|
@mukilan Could you add the try android label? |
jschwe
force-pushed
the
jschwender/servoshell_android
branch
2 times, most recently
from
2f1aaae
to
5fa9c92
Compare
|
🔨 Triggering try run (#9559452801) for Android |
|
✨ Try run (#9559452801) succeeded. |
mrobinson
approved these changes
Jun 18, 2024
jschwe
force-pushed
the
jschwender/servoshell_android
branch
from
5fa9c92
to
70cdd17
Compare
|
Rebased and fixed the conflict |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jschwe
force-pushed
the
jschwender/servoshell_android
branch
from
70cdd17
to
8803842
Compare
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
jschwender/servoshell_android
branch
from
8803842
to
3a31b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the native code of the android app into servoshell.
This change mainly just moves code, adapts the build script to use
--crate-type=cdyliband the nameservoshellon android too.This PR does not attempt to improve codesharing between the android port and the previous servoshell - that is left to future commits.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors