Adding back-off instead of busy-spinning #3505
Conversation
Also changed the total number of spinning similar to Cilk
|
Critic review: https://critic.hoppipolla.co.uk/r/2714 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
| break | ||
| } | ||
| } | ||
|
|
||
| if (i>100) { |
There was a problem hiding this comment.
Could you add a comment saying where this came from? Was this from Cilk, or from performance testing, etc…?
Also, no need for parentheses around if conditions in Rust, just write this as if i > 100.
Additionally, I would make 100 into a constant and hoist it to the top of the file.
|
@LalehB Are you still working on this, or would you like one of us to pick this up and land it with the changes? Thanks! |
I addressed all but one of the code review comments, which was a request for documentation on where a number came from (which I'm not qualified to answer), and rebased this on to latest master. xref: #3505 cc: @LalehB @larsbergstrom r? @pcwalton
Also changed the total number of spinning similar to Cilk