Reverse apply filters. #2150
Merged
Reverse apply filters. #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we do a gecko try for this? |
|
Looks like a few failures (although some of them may be intermittent / unrelated). It'd be good to find out what the cause is though - especially the failures in R7. |
|
|
|
Sounds good, thanks! @bors-servo r+ |
|
📌 Commit c378cf9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 4, 2017
Reverse apply filters. The order of ```composite_ops.filters``` is as same as the order of yaml. But we need reverse apply it to the picture primitive so that the rendering order would match the order of yaml. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2150) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of
composite_ops.filtersis as same as the order of yaml. But we need reverse apply it to the picture primitive so that the rendering order would match the order of yaml.This change is