Share gradient GPU cache entries for repeated gradient primitives. #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a potential fix for the intermittent failures here: servo#2441 (comment) I still can't reproduce them locally. However, I could see that the GPU cache size in that test was getting dangerously close to the maximum size of the texture supported by the GL implementation. That would fit with the issues we're seeing on CI, where there seems to be items not being drawn, and they are affected even though the test in question doesn't draw any gradients. This is not a very elegant fix - however it will hopefully fix the issues we are seeing on CI for now. We can revisit this later to consider a better fix.
This was referenced Feb 22, 2018
|
Try looks green with this patch @staktrace |
kvark
approved these changes
Feb 22, 2018
| pub handle: GpuCacheHandle, | ||
| } | ||
|
|
||
| impl CachedGradient { |
There was a problem hiding this comment.
we should probably just derive(Default) for cases like this
|
@bors-servo r+ |
|
📌 Commit 58a1de7 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 22, 2018
Share gradient GPU cache entries for repeated gradient primitives. This is a potential fix for the intermittent failures here: #2441 (comment) I still can't reproduce them locally. However, I could see that the GPU cache size in that test was getting dangerously close to the maximum size of the texture supported by the GL implementation. That would fit with the issues we're seeing on CI, where there seems to be items not being drawn, and they are affected even though the test in question doesn't draw any gradients. This is not a very elegant fix - however it will hopefully fix the issues we are seeing on CI for now. We can revisit this later to consider a better fix. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2454) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster, status-travis |
|
Fix looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for the intermittent failures here:
#2441 (comment)
I still can't reproduce them locally. However, I could see that the
GPU cache size in that test was getting dangerously close to the
maximum size of the texture supported by the GL implementation.
That would fit with the issues we're seeing on CI, where there
seems to be items not being drawn, and they are affected even
though the test in question doesn't draw any gradients.
This is not a very elegant fix - however it will hopefully fix
the issues we are seeing on CI for now. We can revisit this
later to consider a better fix.
This change is