Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug_font shader has compilation failures #2808

Closed
staktrace opened this issue Jun 6, 2018 · 3 comments · Fixed by #2920
Closed

debug_font shader has compilation failures #2808

staktrace opened this issue Jun 6, 2018 · 3 comments · Fixed by #2920
Labels
bugzilled difficulty: easy type: bug

Comments

@staktrace
Copy link
Contributor

See https://bugzilla.mozilla.org/show_bug.cgi?id=1460442

I think the debug_font shader is only compiled by the DebugRenderer, which only gets used in non-default scenarios (e.g. if a pref is flipped). So that probably accounts for the relatively low volume of crashes. But it happens on a variety of graphics cards so presumably it shouldn't be hard to reproduce and fix.
@kvark
Copy link
Member

kvark commented Jun 6, 2018

called Result::unwrap() on an Err value: Compilation("debug_font", "")

hm, so no actual error message is given?

@kvark
Copy link
Member

kvark commented Jun 6, 2018

The machine I got here is pretty close to one of the repro cases: also Win10, Rx 460 instead of Rx 480, the only suspect-able difference is an older driver (22.19.677.257 as opposed to 24.20.11001.5003 seen in the log). And it works (testing with cargo run --features debugger --example basic). Trying to update the driver to check if it's an upstream regression.

@kvark
Copy link
Member

kvark commented Jun 6, 2018

Hmm, can't repro with 24.20.11019.1004 either. Confirmed that the failing shader is built when running with this command line.

@nical nical mentioned this issue Jul 20, 2018
Merged
bors-servo pushed a commit that referenced this issue Jul 23, 2018
Auto merge of #2920 - nical:debug-shader-build, r=kvark
d2b7cac 
Don't panic when compiling the debug overlay shaders fail.

Fixes #2808.
There is always going to be a silly driver out there that will fail for whatever reason so let's not panic for something that isn't important to the user.
I did leave the unwrap in wrench sort of on purpose because in the unlikely event that someone using wrench hits the driver bug, they'll be in a much better place to fix or report the issue than our average user, and if we are lucky enough to hit this kind of bug a developer's machine we'll be able can try to fix it.

I'm tempted to remove the debug_render feature. It's not buying much since the shader is compiled lazily and it adds noise to the code (and feature flags are annoyingly easy to break).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2920)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilled difficulty: easy type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't panic when compiling the debug overlay shaders fail. nical/webrender
2 participants
@kvark @staktrace