Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display list items for marking content caching region. #3389

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

gw3583
Copy link
Contributor

@gw3583 gw3583 commented Dec 6, 2018

This is an experimental API - we may need to change how this
works, depending on how we integrate it into Gecko.


This change is Reviewable

This is an experimental API - we may need to change how this
works, depending on how we integrate it into Gecko.
@gw3583
Copy link
Contributor Author

gw3583 commented Dec 6, 2018

This provides the API hooks for marking the region(s) of a display list that should be cached, allowing Gecko to specify where the main scroll root for the content region exists.

It doesn't actually do anything with those markers yet, this initial patch is just to see if the API seems reasonable, and allow the Gecko integration work to be done.

Does this seem like all we would need @mstange @mattwoodrow @jrmuizel ?

@gw3583
Copy link
Contributor Author

gw3583 commented Dec 6, 2018

(The scroll root is supplied by the normal WR mechanism, with push/pop clip id methods. We could explicitly make it include the scroll root id if preferred?)

@kvark
Copy link
Member

kvark commented Dec 6, 2018

We've talked about this with @gw3583 a bit, and this appears to be an acceptable interim solution. We can't get this caching scope bound to any existing item, and will in future revise this based on the results.

@kvark
Copy link
Member

kvark commented Dec 7, 2018

@bors-servo r=mstange,mattwoodrow

@bors-servo
Copy link
Contributor

📌 Commit d66727e has been approved by mstange,mattwoodrow

bors-servo pushed a commit that referenced this pull request Dec 7, 2018
Add display list items for marking content caching region.

This is an experimental API - we may need to change how this
works, depending on how we integrate it into Gecko.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3389)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit d66727e with merge 34d5889...

@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: mstange,mattwoodrow
Pushing 34d5889 to master...

@bors-servo bors-servo merged commit d66727e into servo:master Dec 7, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 8, 2018
…befd46c83d47 (WR PR #3389). r=kats

servo/webrender#3389

Differential Revision: https://phabricator.services.mozilla.com/D14000

--HG--
extra : moz-landing-system : lando
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 8, 2018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…befd46c83d47 (WR PR #3389). r=kats

servo/webrender#3389

Differential Revision: https://phabricator.services.mozilla.com/D14000

UltraBlame original commit: 834d7428bc8d134ccbfafc67246a101a30e478e9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…befd46c83d47 (WR PR #3389). r=kats

servo/webrender#3389

Differential Revision: https://phabricator.services.mozilla.com/D14000

UltraBlame original commit: 834d7428bc8d134ccbfafc67246a101a30e478e9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…befd46c83d47 (WR PR #3389). r=kats

servo/webrender#3389

Differential Revision: https://phabricator.services.mozilla.com/D14000

UltraBlame original commit: 834d7428bc8d134ccbfafc67246a101a30e478e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants