-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display list items for marking content caching region. #3389
Conversation
This is an experimental API - we may need to change how this works, depending on how we integrate it into Gecko.
This provides the API hooks for marking the region(s) of a display list that should be cached, allowing Gecko to specify where the main scroll root for the content region exists. It doesn't actually do anything with those markers yet, this initial patch is just to see if the API seems reasonable, and allow the Gecko integration work to be done. Does this seem like all we would need @mstange @mattwoodrow @jrmuizel ? |
(The scroll root is supplied by the normal WR mechanism, with push/pop clip id methods. We could explicitly make it include the scroll root id if preferred?) |
We've talked about this with @gw3583 a bit, and this appears to be an acceptable interim solution. We can't get this caching scope bound to any existing item, and will in future revise this based on the results. |
@bors-servo r=mstange,mattwoodrow |
📌 Commit d66727e has been approved by |
Add display list items for marking content caching region. This is an experimental API - we may need to change how this works, depending on how we integrate it into Gecko. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3389) <!-- Reviewable:end -->
☀️ Test successful - status-appveyor, status-taskcluster |
…befd46c83d47 (WR PR #3389). r=kats servo/webrender#3389 Differential Revision: https://phabricator.services.mozilla.com/D14000 --HG-- extra : moz-landing-system : lando
…befd46c83d47 (WR PR #3389). r=kats servo/webrender#3389 Differential Revision: https://phabricator.services.mozilla.com/D14000
…befd46c83d47 (WR PR #3389). r=kats servo/webrender#3389 Differential Revision: https://phabricator.services.mozilla.com/D14000 UltraBlame original commit: 834d7428bc8d134ccbfafc67246a101a30e478e9
…befd46c83d47 (WR PR #3389). r=kats servo/webrender#3389 Differential Revision: https://phabricator.services.mozilla.com/D14000 UltraBlame original commit: 834d7428bc8d134ccbfafc67246a101a30e478e9
…befd46c83d47 (WR PR #3389). r=kats servo/webrender#3389 Differential Revision: https://phabricator.services.mozilla.com/D14000 UltraBlame original commit: 834d7428bc8d134ccbfafc67246a101a30e478e9
This is an experimental API - we may need to change how this
works, depending on how we integrate it into Gecko.
This change is