Assert against GL errors and check framebuffer completeness #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These enums are extensions, meaning that they aren't necessarily supported. This checking is just nice-to-have, so I'm dropping it rather than adding support for detecting these extensions. Differential Revision: https://phabricator.services.mozilla.com/D14650
Differential Revision: https://phabricator.services.mozilla.com/D14651
Differential Revision: https://phabricator.services.mozilla.com/D14652
Differential Revision: https://phabricator.services.mozilla.com/D14653
|
@bors-servo r=kvark |
|
📌 Commit 3d47763 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 17, 2018
Assert against GL errors and check framebuffer completeness https://bugzilla.mozilla.org/show_bug.cgi?id=1514322 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3428) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 18, 2018
…b51da539bc62 (WR PR #3428). r=kats servo/webrender#3428 Differential Revision: https://phabricator.services.mozilla.com/D14823 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 18, 2018
…b51da539bc62 (WR PR #3428). r=kats servo/webrender#3428 Differential Revision: https://phabricator.services.mozilla.com/D14823
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…b51da539bc62 (WR PR #3428). r=kats servo/webrender#3428 Differential Revision: https://phabricator.services.mozilla.com/D14823 UltraBlame original commit: d65d6d242070557db836baa1fcc3d26529590efa
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…b51da539bc62 (WR PR #3428). r=kats servo/webrender#3428 Differential Revision: https://phabricator.services.mozilla.com/D14823 UltraBlame original commit: d65d6d242070557db836baa1fcc3d26529590efa
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…b51da539bc62 (WR PR #3428). r=kats servo/webrender#3428 Differential Revision: https://phabricator.services.mozilla.com/D14823 UltraBlame original commit: d65d6d242070557db836baa1fcc3d26529590efa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1514322
This change is