ensure lcd filter padding is applied to cbox when rasterizing glyphs with FreeType #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Dec 18, 2018
|
@bors-servo r+ |
|
📌 Commit bfaa542 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 18, 2018
ensure lcd filter padding is applied to cbox when rasterizing glyphs with FreeType This resolves Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1508163 We don't apply the lcd filter padding when querying the cbox to rasterize the glyph, even though we apply the padding when querying the bounds. This causes subpixel AA text to get shifted by the amount of the padding due to the padding not being accounted for in the offset. The solution is to apply the padding in both cases so it properly cancels out. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3432) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 19, 2018
…639f3d748c53 (WR PR #3432). r=kats servo/webrender#3432 Differential Revision: https://phabricator.services.mozilla.com/D14937 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 19, 2018
…639f3d748c53 (WR PR #3432). r=kats servo/webrender#3432 Differential Revision: https://phabricator.services.mozilla.com/D14937
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…639f3d748c53 (WR PR #3432). r=kats servo/webrender#3432 Differential Revision: https://phabricator.services.mozilla.com/D14937 UltraBlame original commit: 774c8752277535794cf081417ac0b0f0fb1b96a1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…639f3d748c53 (WR PR #3432). r=kats servo/webrender#3432 Differential Revision: https://phabricator.services.mozilla.com/D14937 UltraBlame original commit: 774c8752277535794cf081417ac0b0f0fb1b96a1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…639f3d748c53 (WR PR #3432). r=kats servo/webrender#3432 Differential Revision: https://phabricator.services.mozilla.com/D14937 UltraBlame original commit: 774c8752277535794cf081417ac0b0f0fb1b96a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1508163
We don't apply the lcd filter padding when querying the cbox to rasterize the glyph, even though we apply the padding when querying the bounds. This causes subpixel AA text to get shifted by the amount of the padding due to the padding not being accounted for in the offset.
The solution is to apply the padding in both cases so it properly cancels out.
This change is